Skip to content

Refactored adminhtml buttons #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Refactored adminhtml buttons #4402

wants to merge 12 commits into from
+7,557 −2,310

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Dec 7, 2024 •
edited
Loading

Description (*)

  • replaced all $this->getLayout()->createBlock('adminhtml/widget_button')

Added methods

  • getButtonBlock() ... to create a plain button
  • getButtonBlockByType() ... for a button with default values (save/delete/...)

... removed duplicated code, added "some" tests.

@sreichel
add button methods, constants etc
abae43f
@sreichel
cleanup
b9a7836 
- removed inherited methods
- use constants for block
- remove template from constructor
@sreichel
refactor + tests
8946172 
- moved create button code from _prepareLayout to its own methods
- added tests
@sreichel
FIX: need to change methode name b/c parameter conflicts with parent …
c03d4a4 
…method
@sreichel
phpstan
8c21914
@sreichel
rector
76eca58
@sreichel
phpcsfixer
5401426
@sreichel
cleanup
e82eb5b
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Template : admin Relates to admin template Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: Directory Relates to Mage_Directory Component: Uploader Relates to Mage_Uploader phpstan labels Dec 7, 2024
@sreichel sreichel marked this pull request as draft December 18, 2024 14:21
@sreichel sreichel closed this Mar 3, 2025
@sreichel sreichel reopened this Oct 13, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Core Relates to Mage_Core Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget phpstan phpunit Template : admin Relates to admin template

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sreichel