Improved error message for CMS page delete

app/code/core/Mage/Cms/Helper/Page.php

@@ -7,6 +7,8 @@
  * @package    Mage_Cms
  */
 
+use Mage_Adminhtml_Block_System_Config_Form as Form;
+
 /**
  * CMS Page Helper
  *
@@ -29,6 +31,7 @@ class Mage_Cms_Helper_Page extends Mage_Core_Helper_Abstract
      *
      * @param string $pageId
      * @return bool
+     * @throws Mage_Core_Exception
      */
     public function renderPage(Mage_Core_Controller_Front_Action $action, $pageId = null)
     {
@@ -41,8 +44,9 @@ public function renderPage(Mage_Core_Controller_Front_Action $action, $pageId =
      * @param string $pageId
      * @param bool $renderLayout
      * @return bool
+     * @throws Mage_Core_Exception
      */
-    protected function _renderPage(Mage_Core_Controller_Varien_Action  $action, $pageId = null, $renderLayout = true)
+    protected function _renderPage(Mage_Core_Controller_Varien_Action $action, $pageId = null, $renderLayout = true)
     {
         $page = Mage::getSingleton('cms/page');
         if (!is_null($pageId) && $pageId !== $page->getId()) {
@@ -129,6 +133,7 @@ protected function _renderPage(Mage_Core_Controller_Varien_Action  $action, $pag
      * @param string $pageId
      * @param bool $renderLayout
      * @return bool
+     * @throws Mage_Core_Exception
      */
     public function renderPageExtended(Mage_Core_Controller_Varien_Action $action, $pageId = null, $renderLayout = true)
     {
@@ -140,6 +145,7 @@ public function renderPageExtended(Mage_Core_Controller_Varien_Action $action, $
      *
      * @param string $pageId
      * @return string|null
+     * @throws Mage_Core_Model_Store_Exception
      */
     public function getPageUrl($pageId = null)
     {
@@ -176,4 +182,68 @@ public static function getUsedInStoreConfigPaths(?array $paths = []): array
 
         return $searchPaths;
     }
+
+    /**
+     * @param self::XML_PATH_* $path
+     */
+    public static function getConfigLabelFromConfigPath(string $path): string
+    {
+        return match ($path) {
+            self::XML_PATH_NO_ROUTE_PAGE => Mage::helper('cms')->__('No Route Page'),
+            self::XML_PATH_NO_COOKIES_PAGE => Mage::helper('cms')->__('No Cookies Page'),
+            self::XML_PATH_HOME_PAGE => Mage::helper('cms')->__('Home Page'),
+            default => $path,
+        };
+    }
+
+    /**
+     * @param Form::SCOPE_* $scope
+     * @throws Mage_Core_Exception
+     */
+    public static function getScopeInfoFromConfigScope(string $scope, string $scopeId): string
+    {
+        return match ($scope) {
+            Form::SCOPE_ENV => Mage::helper('cms')->__('Environment Config'),
+            Form::SCOPE_DEFAULT => Mage::helper('cms')->__('Default Config'),
+            Form::SCOPE_WEBSITES => Mage::app()->getWebsite($scopeId)->getName(),
+            Form::SCOPE_STORES => sprintf(
+                '%s - %s',
+                Mage::app()->getStore($scopeId)->getGroup()->getName(),
+                Mage::app()->getStore($scopeId)->getName(),
+            ),
+        };
+    }
+
+    /**
+     * @throws Mage_Core_Exception
+     */
+    public static function getValidateConfigErrorMessage(Mage_Core_Model_Resource_Db_Collection_Abstract $isUsedInConfig): string
+    {
+        $messages = [];
+
+        $data = $isUsedInConfig->getData();
+        foreach ($data as $key => $item) {
+            $path = $item['path'];
+            unset($item['config_id'], $item['path'], $item['updated_at'], $item['value']);
+            $data[$path][] = $item;
+            unset($data[$key], $key, $path);
+        }
+
+        foreach ($data as $path => $items) {
+            $scopes = [];
+            foreach ($items as $item) {
+                $scopes[] = self::getScopeInfoFromConfigScope($item['scope'], $item['scope_id']);
+            }
+
+            $messages[] = sprintf(
+                '%s (%s)',
+                self::getConfigLabelFromConfigPath($path),
+                implode(', ', $scopes),
+            );
+        }
+
+        unset($data, $path, $items, $item, $scopes);
+
+        return implode(', ', $messages);
+    }
 }

app/code/core/Mage/Cms/Model/Resource/Page.php

@@ -39,8 +39,9 @@ protected function _beforeDelete(Mage_Core_Model_Abstract $object)
                 $object->setId(null);
                 Mage::throwException(
                     Mage::helper('cms')->__(
-                        'Cannot delete page, it is used in "%s".',
-                        implode(', ', $isUsedInConfig->getColumnValues('path')),
+                        'You cannot delete this page as it is used to <a href="%s">configure</a> %s.',
+                        Mage::helper('adminhtml')::getUrl('adminhtml/system_config/edit', ['section' => 'web']),
+                        Mage_Cms_Helper_Page::getValidateConfigErrorMessage($isUsedInConfig),
                     ),
                 );
             }
@@ -79,8 +80,9 @@ protected function _beforeSave(Mage_Core_Model_Abstract $object)
                 $object->setIsActive(true);
                 Mage::getSingleton('adminhtml/session')->addWarning(
                     Mage::helper('cms')->__(
-                        'Cannot disable page, it is used in configuration "%s".',
-                        implode(', ', $isUsedInConfig->getColumnValues('path')),
+                        'You cannot disable this page as it is used to <a href="%s">configure</a> %s.',
+                        Mage::helper('adminhtml')::getUrl('adminhtml/system_config/edit', ['section' => 'web']),
+                        Mage_Cms_Helper_Page::getValidateConfigErrorMessage($isUsedInConfig),
                     ),
                 );
             }
@@ -111,6 +113,7 @@ protected function _beforeSave(Mage_Core_Model_Abstract $object)
     /**
      * @param Mage_Cms_Model_Page $object
      * @inheritDoc
+     * @throws Zend_Db_Exception
      */
     protected function _afterSave(Mage_Core_Model_Abstract $object)
     {
@@ -185,6 +188,7 @@ protected function _afterLoad(Mage_Core_Model_Abstract $object)
      * @param mixed $value
      * @param Mage_Cms_Model_Page $object
      * @return Zend_Db_Select
+     * @throws Exception
      */
     protected function _getLoadSelect($field, $value, $object)
     {
@@ -236,6 +240,7 @@ protected function _getLoadByIdentifierSelect($identifier, $store, $isActive = n
     /**
      * Check for unique of identifier of page to selected store(s).
      *
+     * @param Mage_Cms_Model_Page $object
      * @return bool
      */
     public function getIsUniquePageToStores(Mage_Core_Model_Abstract $object)
@@ -282,7 +287,9 @@ protected function isValidPageIdentifier(Mage_Core_Model_Abstract $object)
 
     public function getUsedInStoreConfigCollection(Mage_Cms_Model_Page $page, ?array $paths = []): Mage_Core_Model_Resource_Db_Collection_Abstract
     {
-        $storeIds   = (array) $page->getStoreId();
+        $storeId    = (array) $page->getStoreId(); # null on save
+        $stores     = (array) $page->getStores(); # null on delete
+        $storeIds   = array_merge($storeId, $stores);
         $storeIds[] = Mage_Core_Model_App::ADMIN_STORE_ID;
         $config     = Mage::getResourceModel('core/config_data_collection')
             ->addFieldToFilter('value', $page->getIdentifier())
@@ -326,6 +333,7 @@ public function checkIdentifier($identifier, $storeId)
      *
      * @param string|int $identifier
      * @return string
+     * @throws Mage_Core_Model_Store_Exception
      */
     public function getCmsPageTitleByIdentifier($identifier)
     {
@@ -418,6 +426,7 @@ public function setStore($store)
      * Retrieve store model
      *
      * @return Mage_Core_Model_Store
+     * @throws Mage_Core_Model_Store_Exception
      */
     public function getStore()
     {

app/locale/en_US/Mage_Cms.csv

@@ -27,10 +27,8 @@
 "CMS Static Block","CMS Static Block"
 "CMS Static Block Default Template","CMS Static Block Default Template"
 "Cannot create new directory.","Cannot create new directory."
-"Cannot delete page, it is used in ""%s"".","Cannot delete page, it is used in ""%s""."
 "Cannot delete directory %s.","Cannot delete directory %s."
 "Cannot delete root directory %s.","Cannot delete root directory %s."
-"Cannot disable page, it is used in configuration ""%s"".","Cannot disable page, it is used in configuration ""%s""."
 "Cannot upload file.","Cannot upload file."
 "Collapse All","Collapse All"
 "Content","Content"
@@ -124,4 +122,6 @@
 "Unable to find a block to delete.","Unable to find a block to delete."
 "Unable to find a page to delete.","Unable to find a page to delete."
 "WYSIWYG Options","WYSIWYG Options"
+"You cannot delete this page as it is used to <a href=""%s"">configure</a> %s.","You cannot delete this page as it is used to <a href=""%s"">configure</a> %s."
+"You cannot disable this page as it is used to <a href=""%s"">configure</a> %s.","You cannot disable this page as it is used to <a href=""%s"">configure</a> %s."
 "px.","px."

cypress/e2e/openmage/backend/cms/page.cy.js

@@ -61,7 +61,7 @@ describe(`Checks admin system "${test.index.title}"`, () => {
         test.edit.__buttons.saveAndContinue.click();
 
         const success = 'The page has been saved.';
-        const warning = 'Cannot disable page, it is used in configuration';
+        const warning = 'You cannot disable this page as it is used to configure';
         validation.hasWarningMessage(warning);
         validation.hasSuccessMessage(success);
         utils.screenshot(cy.openmage.validation._messagesContainer, 'message.cms.page.disableActivePage');
@@ -71,7 +71,7 @@ describe(`Checks admin system "${test.index.title}"`, () => {
         test.index.clickGridRow('no-route');
         test.edit.__buttons.delete.click();
 
-        const message = 'Cannot delete page';
+        const message = 'You cannot delete this page as it is used to configure';
         const screenshot = 'message.cms.page.deleteActivePage';
         validation.hasErrorMessage(message, { screenshot: true, filename: screenshot });
     });