PHP8.5: fix null array offset #5028
Open
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Core
There was a problem hiding this comment.
Pull Request Overview
This PR addresses null array offset deprecation warnings in PHP 8.5 by adding null checks and type coercion before array access operations. The changes prevent potential issues where null values are used as array keys or offsets.
Key Changes:
- Added null checks with empty string fallback before array key access in multiple methods
- Added explicit string type casting for array keys to prevent null offset warnings
- Removed a potentially problematic
curl_close()call that could fail if the resource was already null
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Varien/Http/Adapter/Curl.php | Removed curl_close call to prevent errors when resource is null |
| lib/Varien/Data/Collection.php | Added null check converting null to empty string before array access |
| app/code/core/Mage/Index/Model/Indexer/Abstract.php | Added null check converting null to empty string before array access |
| app/code/core/Mage/Core/Controller/Varien/Router/Standard.php | Added string cast to prevent null as array key |
| app/code/core/Mage/CatalogInventory/Model/Stock/Status.php | Added string cast to prevent null as array key |
| app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php | Added null check converting null to empty string before array access |
| app/code/core/Mage/Catalog/Model/Product/Type.php | Added string cast to prevent null as array key |
Comments suppressed due to low confidence (1)
app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php:1
- Converting null to empty string will result in a less informative error message on line 319 ('Unsupported product type ""'). Consider checking for null explicitly and throwing a more specific exception like 'Product type ID cannot be null' to aid debugging.
<?php
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/OpenMage/magento-lts/actions/runs/18709139113/job/53353233192