Tests: cypress update - add admin store switcher helper #5045
+203
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Cypress test infrastructure for system configuration testing by centralizing common configuration patterns and introducing a new test suite for general store settings.
Key changes:
- Introduces a centralized
__systemConfigbase object to reduce code duplication across system configuration tests - Adds new support and test structure for general configuration section (store information)
- Refactors existing test files to use the standardized
config.clickSave()method instead of deprecatedcy.adminSaveConfiguration() - Enhances validation utility to handle optional CSS validation checks
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cypress/support/openmage/backend/system/config/general/general.js | Defines configuration objects for the General system settings section with store information fields |
| cypress/support/openmage/backend/system/config/catalog/sitemap.js | Refactors to use centralized __systemConfig and reorganizes priority fields into separate category/product/page objects |
| cypress/support/openmage/_utils/validation.js | Adds conditional check for optional CSS validation in field filling logic |
| cypress/support/openmage/_utils/test.js | Adds __systemConfig base object, updates JSDoc formatting, and creates namespace for general configuration tests |
| cypress/support/openmage/_utils/admin.js | Adds goToConfigScope helper function for store switcher navigation |
| cypress/support/e2e.js | Imports new general configuration support file |
| cypress/e2e/openmage/backend/system/config/general/general.cy.js | Empty test file placeholder |
| cypress/e2e/openmage/backend/system/config/catalog/sitemap.cy.js | Updates to use config.clickSave() and restructured __groupPriority fields |
| cypress/e2e/openmage/backend/system/config/catalog/configswatches.cy.js | Replaces deprecated cy.adminSaveConfiguration() with config.clickSave() |
Co-authored-by: Copilot <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.