Replace Zend_Measure with php-units-of-measure
#5102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Core
Copilot finished reviewing on behalf of
sreichel
November 15, 2025 08:37
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Zend_Measure library with the php-units-of-measure library for unit conversion functionality. This is part of modernizing dependencies and moving away from Zend Framework components.
Key Changes:
- Adds
php-units-of-measurev2.2.0 as a new dependency - Introduces new helper classes with measurement unit constants
- Refactors unit conversion methods to use the new library's API
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Adds php-units-of-measure dependency |
| composer.lock | Includes the new library metadata |
| app/code/core/Mage/Core/Helper/Measure/Weight.php | New helper class defining weight unit constants |
| app/code/core/Mage/Core/Helper/Measure/Length.php | New helper class defining length unit constants |
| app/code/core/Mage/Usa/Helper/Data.php | Refactored conversion methods to use new library API |
| app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php | Updated to use new measurement constants |
| app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php | Updated to use new measurement constants |
| app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php | Updated to use new measurement constants |
| app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php | Updated to use new measurement constants |
| app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php | Updated to use new measurement constants |
| app/code/core/Mage/Usa/Block/Adminhtml/Dhl/Unitofmeasure.php | Updated to use new measurement constants |
| app/design/adminhtml/default/default/template/sales/order/shipment/packaging/popup.phtml | Updated template to use new measurement constants |
| tests/unit/Mage/Usa/Helper/DataTest.php | New unit tests for conversion methods |
| tests/unit/Traits/DataProvider/Mage/Usa/Helper/DataTrait.php | New test data provider trait |
| .phpunit.dist.xml | Added Mage_Usa test suite |
| .phpstan.dist.baseline.neon | Updated baseline with new exceptions |
Hanmac
previously approved these changes
Nov 16, 2025
# Conflicts: # composer.lock
sreichel
force-pushed
the
zend-measure
branch
from
c309d62 to
991b8cb
Compare
# Conflicts: # .phpstan.dist.baseline.neon # app/code/core/Mage/Usa/Helper/Data.php
# Conflicts: # .phpstan.dist.baseline.neon # app/code/core/Mage/Usa/Helper/Data.php
|
Contributor
|
Why can't phpstan find: |
Contributor
Author
|
What do you mean? One commit was not complete, but that should be fixed. |
Hanmac
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.