Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for development with k8s #8805

Merged
merged 14 commits into from
May 30, 2024
Merged

Documentation for development with k8s #8805

merged 14 commits into from
May 30, 2024

Conversation

snwagh
Copy link
Contributor

@snwagh snwagh commented May 13, 2024 •
edited
Loading

Description

  • Adding 07-deploy-devspace.ipynb which closes this issue
  • Few additions to 03-deploy-k8s-k3d.ipynb:
    • Resource constraint deployment instructions
    • Custom password setup during deployment or extracting randomized password post deployment

Testing

  • Tested over bash until Docker account got frozen. Works.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@snwagh snwagh changed the base branch from dev to tauquir/local-k8s-quickstart-doc May 13, 2024 17:42
@khoaguin
Copy link
Member

Hi @snwagh can we add the newly made commands to launch different types of nodes into the tutorial, for example:

  1. For Launching a Domain
CLUSTER_NAME=testdomain1 CLUSTER_HTTP_PORT=9082 tox -e dev.k8s.launch.domain
  1. For Launching a Gateway
CLUSTER_NAME=testgateway1 CLUSTER_HTTP_PORT=9081 tox -e dev.k8s.launch.gateway
  1. For Launching a Enclave
CLUSTER_NAME=testenclave1 CLUSTER_HTTP_PORT=9083 tox -e dev.k8s.launch.enclave
  1. For launching nodes with hotreload:
tox -e dev.k8s.domain -- hotreload

@snwagh
Copy link
Contributor Author

snwagh commented May 14, 2024

@khoaguin Great suggestion, added these.

@snwagh snwagh requested a review from itstauq May 14, 2024 14:59
Base automatically changed from tauquir/local-k8s-quickstart-doc to dev May 17, 2024 09:29
IrinaMBejan
IrinaMBejan suggested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@IrinaMBejan IrinaMBejan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Just a few nit comments.

notebooks/tutorials/deploy/07-deploy-devspace.ipynb Outdated Show resolved Hide resolved
notebooks/tutorials/deploy/07-deploy-devspace.ipynb Outdated Show resolved Hide resolved
@snwagh snwagh requested a review from IrinaMBejan May 17, 2024 19:34
@itstauq itstauq changed the title Documentataion for development with k8s Documentation for development with k8s May 22, 2024
@snwagh snwagh enabled auto-merge May 29, 2024 17:22
@snwagh snwagh disabled auto-merge May 30, 2024 13:52
@snwagh
Merge branch 'snwagh/documentataion-for-dev-with-k8s' of github.com:O…
428b07b 
…penMined/PySyft into snwagh/documentataion-for-dev-with-k8s
@snwagh snwagh enabled auto-merge May 30, 2024 13:53
@snwagh snwagh requested review from rasswanth-s and removed request for madhavajay and yashgorana May 30, 2024 13:59
@snwagh snwagh merged commit 9742ade into dev May 30, 2024
26 checks passed
@snwagh snwagh deleted the snwagh/documentataion-for-dev-with-k8s branch May 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IrinaMBejan IrinaMBejan IrinaMBejan approved these changes

@itstauq itstauq itstauq approved these changes

@rasswanth-s rasswanth-s Awaiting requested review from rasswanth-s

Assignees
No one assigned
Labels
0.8.7 Purple Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snwagh @khoaguin @IrinaMBejan @itstauq @madhavajay