feat(fcau): add health certificate generation content - #32
Open
mushrafmim wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
Adds the FCAU Health Certificate gohtml template and wires it up end to end so an agency officer can generate a populated certificate for a consignment via the nsw-agency backend's POST /certificates/generate: - fcau_issue_certificate/certificate_template.gohtml: the certificate, sourcing consignor/consignee/product/vessel/port/destination/etc. fields directly from the consignment's fcau_application_review_v1 application via fromData/fromReview template functions, with only certificate_id and additional_declarations left as officer input. - fcau_issue_certificate_v1.json: declares the certificate template via a new "certificate.templateId" field on the task config. - officerinput_jsonform.json: adds the additional_declarations field the officer fills in alongside certificate_id. - manifest.json: registers the new certificate_template artifact. - port_and_country_of_loading / country_of_destination added to every fcau task's userinput_jsonform.json (trader input, since the trader — not the officer — knows shipping details) so the certificate's "Port and Country of Loading" / "Country of Destination" fields have a source; kept consistent across all fcau task view forms. - tnsw/fcau/1-application/workflow.json: the applicant_submission node's output_mapping was missing port_and_country_of_loading and country_of_destination, silently dropping them from global workflow state before they could ever reach the agency backend — added. Companion backend/frontend PR: OpenNSW/nsw-agency (certificate generation API + officer UI).
mushrafmim
force-pushed
the
feat/fcau-certificate-generation
branch
from
August 23, 2026 00:45
dfb32a8 to
064a263
Compare
ginaxu1
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion content for the FCAU Health Certificate generation feature (backend + officer UI in OpenNSW/agency#226).
fcau_issue_certificate/certificate_template.gohtml, anhtml/templatedocument sourcing consignor/consignee/product/vessel/port/destination/etc. fields directly from the consignment'sfcau_application_review_v1application viafromData/fromReviewtemplate functions. Onlycertificate_idandadditional_declarationsare officer-supplied.fcau_issue_certificate_v1.jsondeclares the template via a newcertificate.templateIdfield on the task config.officerinput_jsonform.jsonaddsadditional_declarations.manifest.jsonregisters the newcertificate_templateartifact.port_and_country_of_loading/country_of_destinationadded to everyfcau_*task'suserinput_jsonform.json(trader input, since the trader — not the officer — knows shipping details), kept consistent across all fcau task view forms, so the certificate has a source for those two fields.tnsw/fcau/1-application/workflow.json: theapplicant_submissionnode'soutput_mappingwas missing both fields, silently dropping them from global workflow state before they could reach the agency backend — fixed.Testing
certificate_template.gohtmlvalidated withhtml/template(parses cleanly, including thefromData/fromReview/todaycalls).Related
Companion PR: OpenNSW/agency#226 (certificate generation API + officer UI).