fix: keep stale needs_more_info copy out of trader status after resubmit - #54
Open
ginaxu1 wants to merge 1 commit into
Open
fix: keep stale needs_more_info copy out of trader status after resubmit#54ginaxu1 wants to merge 1 commit into
ginaxu1 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same-step correction loops were still showing "please resubmit" as current status in QUEUED_EXTERNALLY because leftover officer outcome data was not gated by task state. Split awaiting vs action-required banners the same way as the SLTB blendsheet fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Aravinda-HWK
force-pushed
the
fix/stale-needs-more-info-after-resubmit
branch
from
September 6, 2026 05:26
d5bdccf to
6261721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/LSFLK/lsf-govtech-tnsw/issues/103
Recreation of #52 on latest
main(#49 is already merged). Same defect class on other same-stepneeds_more_infoloops: after the trader resubmits,QUEUED_EXTERNALLYstill showed leftover officer “please correct / resubmit” copy as current status.Summary
PENDING_USER/COMPLETED: action-required or terminal assessment (deficiencies, approve).QUEUED_EXTERNALLY: Current Status (submitted vs resubmitted, awaiting officer). Prior officer comments move to Review History.Not changed: split-step loops (NPQS docs upload↔review, treatment-cert upload↔review), SLTB levy, CDA lot adjustment, SLTB pickup scheduling — those already hide correction copy except when the trader can act.
Test plan
QUEUED_EXTERNALLYshows submitted / awaiting; no deficiency banner; no Review Historyneeds_more_info→PENDING_USERshows deficiencies / “please resubmit”QUEUED_EXTERNALLYshows resubmitted / awaiting; officer comments only under Review HistoryCOMPLETEDshows the terminal assessment, not the old correction copy