feat(cda): upload revised DC bag Excel on lot adjustment - #64
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ginaxu1
marked this pull request as draft
September 8, 2026 09:09
ginaxu1
force-pushed
the
feat/cda-lot-adj-excel-upload
branch
from
September 8, 2026 09:21
6a36bcf to
13a8e81
Compare
ginaxu1
marked this pull request as ready for review
September 8, 2026 14:14
Replace the free-text lots-to-remove field with an Excel file upload so traders submit amended bag details the same way as the original application. Co-authored-by: Cursor <cursoragent@cursor.com>
Reuse the existing application bag-details template so traders download the same sheet, fill the amended bag list, and upload it instead of typing. Co-authored-by: Cursor <cursoragent@cursor.com>
Leave lots_to_remove as the mapped field so officer inject still works. The trader form still shows an Excel upload for that field. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
force-pushed
the
feat/cda-lot-adj-excel-upload
branch
from
September 8, 2026 14:15
d3edd9c to
c272a2d
Compare
Contributor
Author
|
Full flow here (with CDA officer requesting resubmit, and Trader resubmitting) https://github.com/LSFLK/lsf-govtech-tnsw/issues/108#issuecomment-5586151204 |
CDA validates inject data against the trader form, which requires adjustment_choice. Without it the inject is rejected and the officer never sees a pending review task. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
force-pushed
the
feat/cda-lot-adj-excel-upload
branch
from
September 8, 2026 15:01
7aab50f to
cf2eda5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves LSFLK/lsf-govtech-tnsw#108
Summary
On the CDA process 01 lot adjustment path, traders currently type amended bag details into a free-text field. This change lets them download the existing DC bag details Excel template, fill in the amended bag list, and upload that sheet instead, so the officer can re-issue the salmonella/physical quality certificate against the amended bag quantity for the existing CusDec/consignment.
Template: https://docs.google.com/spreadsheets/d/1nVT_Q2S59KRUD-JWZy_gnjsYNnswjOsnDHdoJMHKzZ4/edit?gid=0#gid=0
Changes Made
Verification
Manual verification (see screen recording https://github.com/LSFLK/lsf-govtech-tnsw/issues/108#issuecomment-5586151204)