feat(npqs): load tea and coconut commodity names from static data - #65
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ginaxu1
force-pushed
the
feat/npqs-tea-coconut-commodity-dropdowns
branch
2 times, most recently
from
September 7, 2026 07:02
ca7938a to
07114f5
Compare
Contributor
Author
Screen.Recording.2026-09-07.at.12.28.46.movbasically this but Ive since updated the dropdown values to be Title-cased, so "Sea Coconut Palm" instead of "sea coconut palm" |
Replace the free-text commodity common name field with an x-search dropdown sourced from a single static_data artifact, matching the importing-country pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
ginaxu1
force-pushed
the
feat/npqs-tea-coconut-commodity-dropdowns
branch
from
September 8, 2026 03:53
07114f5 to
dac89ea
Compare
mushrafmim
approved these changes
Sep 8, 2026
Contributor
There was a problem hiding this comment.
LGTM! I tested manually. It's working E2E. But @Aravinda-HWK needs to approve.
Aravinda-HWK
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional request from Poorima in https://github.com/LSFLK/lsf-govtech-tnsw/issues/84
Values based on last 2 tabs "Coconut" and "Tea" in this Spreadsheet
Summary
NPQS phytosanitary application Commodity Common Name is now a dropdown of tea and coconut commodity names, loaded from one static_data artifact instead of a hardcoded list in each form copy.
Changes Made
tnsw/npqs/1-apply/commodity_common_names.data.jsonwith 49 unique tea and coconut common names (case-duplicate "common coconut palm" omitted).tnsw/manifest.jsonasnpqs-apply-phyto-cert--commodity-common-names(kind: static_data).commodity_common_nameon all 10 copies ofnpqs-apply-phyto-cert--user-format that artifact viax-search(static-data,small-list), same pattern as importing country in PR refactor(npqs): load importing country list from static data artifact #60.{ value, label }to match the submitted object.Verification
Manually verified. Confirmed the trader apply form renders the tea/coconut dropdown, selecting a name saves
{ value, label }, officer views show the selected label, and all user-form copies stay identical.