fix(cda-kcfn): stop trader re-uploading recommendation letter, add necessary documents

[mushrafmim]

Summary

Addresses feedback from @Poornima-Raleen on the CDA King Coconut / Fresh Nuts Recommendation flow (cda/2-king-coconut-fresh-nuts-recommendation/ + tnsw/cda/2-king-coconut-fresh-nuts-recommendation/), per LSFLK/lsf-govtech-tnsw#3 and specifically this comment:

• Q1: Step 4 ("Upload Documents") no longer asks the trader to re-upload the recommendation letter the officer just issued in step 3 — the letter is only ever downloaded, following the CDA Process 1 pattern. Removed uploaded_letter_file from the step 4 trader form and its workflow/macro-workflow mappings, and updated the step 3 trader instructions text accordingly.
• Q2: Per the BPMN, step 4 now asks the trader for the "Necessary Documents": two new required upload fields, Commercial Invoice and Packing List. The pre-existing generic multi-file field was kept as an optional catch-all, renamed from "Reports" to "Additional Documents" for clarity now that it's supplementary to the two named uploads.
• Updated officer-facing verification form wording, status/outcome messages, and the agency-side task_config description to match, and kept both duplicate copies of cda-kcfn-upload-docs--user-form / cda-kcfn-asycuda-verification--officer-form (tnsw/ and agency-side) byte-identical per repo convention.

Test plan

• python3 .claude/skills/nsw-trade-flows/scripts/validate_artifacts.py --root . — no new errors/warnings for cda-kcfn artifacts (only pre-existing, unrelated drift in other agencies)
• Diffed duplicate form copies (tnsw/cda/.../4-upload_documents/userinput_jsonform.json vs cda/.../cda_kcfn_asycuda_verification/userinput_jsonform.json) — byte-identical

Summary by CodeRabbit

• New Features

  • Updated the document submission workflow to collect required Commercial Invoice and Packing List files.
  • Added support for optional additional supporting documents.
  • Updated officer verification and review screens to reference the submitted documents.

• Documentation

  • Updated workflow titles, instructions, notifications, and confirmation messages to reflect the document submission process.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9eef96df-0c1d-465b-8014-21cc17d640aa

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 247b93ce-0860-4f3f-b7ce-857b62b7c506

📥 Commits

Reviewing files that changed from the base of the PR and between 17d49f6 and e7c3502.

📒 Files selected for processing (11)

• cda/2-king-coconut-fresh-nuts-recommendation/cda_kcfn_asycuda_verification/cda_kcfn_asycuda_verification_v1.taskconfig.json
• cda/2-king-coconut-fresh-nuts-recommendation/cda_kcfn_asycuda_verification/officerinput_jsonform.json
• cda/2-king-coconut-fresh-nuts-recommendation/cda_kcfn_asycuda_verification/userinput_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/3-issue_recommendation_letter/trader_results_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/officer_review_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/render.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/submitted_message_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/userinput_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/verified_message_jsonform.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/4-upload_documents/workflow.json
• tnsw/cda/2-king-coconut-fresh-nuts-recommendation/cda_workflow.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The workflow replaces recommendation-letter uploads with required commercial invoices and packing lists, optional additional documents, updated state mappings, and matching verification messages.

Changes

Necessary Document Upload Workflow

Layer / File(s)	Summary
Document upload form contract cda/2-king-coconut-fresh-nuts-recommendation/cda_kcfn_asycuda_verification/userinput_jsonform.json, tnsw/cda/.../4-upload_documents/userinput_jsonform.json	The forms now require commercial_invoice and packing_list, with optional additional_documents. Examples and UI scopes use the new properties.
Workflow state mapping tnsw/cda/.../4-upload_documents/workflow.json, tnsw/cda/.../cda_workflow.json	The upload task and CDA workflow now map the new document fields and remove the previous recommendation-letter fields.
Verification labels and messages cda/2-king-coconut-fresh-nuts-recommendation/cda_kcfn_asycuda_verification/*, tnsw/cda/.../3-issue_recommendation_letter/trader_results_jsonform.json, tnsw/cda/.../4-upload_documents/{officer_review_jsonform.json,render.json,submitted_message_jsonform.json,verified_message_jsonform.json}	Task descriptions, form labels, workflow titles, and notification messages now refer to commercial invoices, packing lists, supporting documents, or necessary documents.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e7c35

The workflow now collects the required commercial invoice and packing list without requiring traders to re-upload the issued recommendation letter. The updated forms, mappings, and messages are aligned, with no current merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: removing recommendation-letter re-uploading and adding the required documents.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/support-cda-process-2-additional-requirements

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}