Skip to content

feat(cda): add value-added DC ASYCUDA green-check path - #71

Merged
ginaxu1 merged 2 commits into
mainfrom
feat/cda-green-path
Sep 10, 2026
Merged

feat(cda): add value-added DC ASYCUDA green-check path#71
ginaxu1 merged 2 commits into
mainfrom
feat/cda-green-path

Conversation

@ginaxu1

@ginaxu1 ginaxu1 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the CDA Process 01 exception path so a consignment made up only of value-added or low-fat DC can be approved with an ASYCUDA green check instead of going through payment, quality check, and certificate issuance.

Implements https://github.com/LSFLK/lsf-govtech-tnsw/issues/110

Changes Made

  • CDA Officer step to approve Trader-submitted application now includes Product Type as DC and/or Value Added DC - Low Fat DC (at least one required).
  • If "Value Added DC - Low Fat DC" is selected with Officer approval, skips payment, quality check, certificate issuance, and lot adjustment. The CDA officer then puts a green check on ASYCUDA.
  • DC (alone or mixed with value-added) keeps the existing path: payment, certificate issuance, then lot adjustment. The review officer makes the final approval after the DC certificate path.

Manual Testing Steps

  • Confirm the trader application form has no Product Type and no Payment Category. Required Certificates (Salmonella Free / Physical Quality) stay visible as on the existing application form.
  • Submit an application. On CDA Application Verification, select Needs More Information: confirm Product Type is hidden, comments are required, and the application is sent back to the trader.
  • Submit an application. Officer selects Approve Verification and only Value Added DC - Low Fat DC. Confirm submit is blocked if neither product type is checked. Confirm payment, quality check, certificate issuance, and lot adjustment are skipped. Confirm a CDA officer ASYCUDA green-check task appears, and completing it (green check confirmed in ASYCUDA) ends the flow.
  • Submit an application. Officer selects Approve Verification and only DC. Confirm the flow still goes to payment, then officer certificate issuance, then lot adjustment.
  • Submit an application. Officer selects Approve Verification and both product types. Confirm it follows the DC certificate path, and the review officer still issues the Salmonella/product quality certificate for the DC items.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8c513749-86e5-47f8-b8dc-82f265750dd5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ginaxu1
ginaxu1 marked this pull request as draft September 8, 2026 15:02
@ginaxu1
ginaxu1 force-pushed the feat/cda-green-path branch 2 times, most recently from 80642f5 to b87b0f6 Compare September 9, 2026 04:18
@ginaxu1

ginaxu1 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

What Trader and CHA each see at the end of Green Path:
Screenshot 2026-09-09 at 10 12 10
Screenshot 2026-09-09 at 10 12 14

Rference BPMN: https://drive.google.com/drive/folders/1cmWtpikoEsrm3gK75s5ArwUims3oYTx8
BPMN - CDA - Process 1 - Issuance of Salmonella Free and Physical Quality Certificate (CDA) V4

@ginaxu1
ginaxu1 marked this pull request as ready for review September 9, 2026 04:51
@ginaxu1
ginaxu1 force-pushed the feat/cda-green-path branch from b87b0f6 to 6f485d5 Compare September 9, 2026 05:09
ginaxu1 and others added 2 commits September 9, 2026 17:42
Exclusive Value Added DC or Low Fat DC consignments skip quality check
and certificate issuance after application review and payment.

Co-authored-by: Cursor <cursoragent@cursor.com>
Split after application review so exclusive Value Added DC or Low Fat DC
skips payment and certificate issuance, then waits on a CDA officer
ASYCUDA green check. DC or mixed consignments keep the existing path.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ginaxu1
ginaxu1 force-pushed the feat/cda-green-path branch from 6f485d5 to 241ea72 Compare September 9, 2026 12:12

@Aravinda-HWK Aravinda-HWK left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ginaxu1
ginaxu1 merged commit 7f51765 into main Sep 10, 2026
2 checks passed
@ginaxu1
ginaxu1 deleted the feat/cda-green-path branch September 10, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants