jsonforms-renderers(spreadsheet): separate spreadsheet matrix processing from parsing

[sthanikan2000]

Summary

Pure, behavior-preserving refactor: extracts the "evaluate formulas against an already-parsed matrix, then shape the persisted value" step out of SpreadsheetControl's processFile callback into a standalone, format-agnostic processMatrix() helper (new utils/spreadsheet/process.ts).

• parseWorkbookToMatrix (xlsx/csv-specific) is untouched.
• A future upload format that produces the same CellValue[][] matrix shape (e.g. XML) could reuse processMatrix without duplicating the evaluate-and-shape logic — no such format is added here, this PR only creates the reusable seam.
• Relocates SpreadsheetValue out of SpreadsheetControl.tsx into the shared utils/spreadsheet types, since it's no longer private to one renderer.
• derivations stays array-shaped here, unchanged from main — the next PR in the stack adds mandatory id and converts this to an id-keyed map, deliberately split out so this PR stays a genuine no-behavior-change refactor with no id concept involved at all.

(Replaces the original #25, which GitHub auto-flagged as "merged" after a stack-restructuring force-push made its old head commit reachable from its old base branch — no code ever reached main; this PR carries the same content rebased directly onto #23.)

Test plan

• pnpm type-check and pnpm test pass (new process.test.ts covers persistSheet true/false, empty formulas, error-entry passthrough)
• Manually verified in the dev playground: grid and "Computed values" panel render identically to before this PR

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added consistent spreadsheet processing for uploaded data and formula derivations.
  • Spreadsheet values can now preserve the original sheet alongside calculated results.

• Bug Fixes

  • Improved handling of formula evaluation errors while retaining successful calculations.

• Tests

  • Added coverage for default and configurable sheet persistence, empty formulas, successful calculations, and mixed evaluation results.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b514f8b0-b521-4f32-8352-102c934b1687

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 8bd66869-3602-49eb-ac56-79aee81be5ec

📥 Commits

Reviewing files that changed from the base of the PR and between cb76d53 and 9853559.

📒 Files selected for processing (5)

• packages/jsonforms-renderers/src/renderers/SpreadsheetControl.tsx
• packages/jsonforms-renderers/src/utils/spreadsheet/index.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/process.test.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/process.ts
• packages/jsonforms-renderers/src/utils/spreadsheet/types.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Spreadsheet processing

Layer / File(s)	Summary
Matrix processing contract and implementation packages/jsonforms-renderers/src/utils/spreadsheet/types.ts, packages/jsonforms-renderers/src/utils/spreadsheet/process.ts, packages/jsonforms-renderers/src/utils/spreadsheet/process.test.ts, packages/jsonforms-renderers/src/utils/spreadsheet/index.ts	Adds the shared SpreadsheetValue contract and processMatrix helper. The helper evaluates formulas and optionally persists the source matrix. Tests cover persistence options, successful evaluations, empty results, and errors.
Spreadsheet upload integration packages/jsonforms-renderers/src/renderers/SpreadsheetControl.tsx	Updates spreadsheet uploads to call processMatrix and pass its returned value to handleChange. Uses the shared SpreadsheetValue type.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 98535

This PR extracts existing spreadsheet matrix processing into a reusable helper without changing parsing or persisted data behavior. It is merge-ready after normal checks, with no actionable merge-blocking risk remaining.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 5 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: separating spreadsheet matrix processing from parsing. It is concise, specific, and consistent with the PR objectives.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/spreadsheet-parse-process-split

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ginaxu1]

Lgtm