fix: handle formatBytes edge cases#16
Open
Jaco-Ren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
formatBytesedge cases reported in #15:Bunit instead of producingundefinedPBandEBunits and clamp the selected unit index for very large valuesvite.config.tsThis differs from the existing #13 by covering the
>= 1 PiBcase and preserving the invalid-size placeholder behavior requested in #15.Verification
npm.cmd test -- --run src/lib/utils.test.ts npm.cmd run typecheck npm.cmd run buildI also checked the touched files with ESLint. The full existing lint command still reports pre-existing
no-explicit-anyerrors insrc/components/code/BlueprintGraph.tsx, unrelated to this change.Fixes #15