Updates python codebase to the head of the matlab development branch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced README with installation instructions for both virtualenv and conda. - Added requirements.txt to specify necessary Python packages for the project.
… safety checks Refactor the safety checks in both functions to use a loop for combining the results of multiple checks. This improves code readability and maintainability by reducing redundancy. This refactor is done to update the python recovery repo to commit f6ea7c6 in the matlab recovery repo
Introduce options to control the tagging behavior of coupling beams in the red tag assessment. This includes the ability to ignore coupling beams for red tag calculations and to tag them based on height. These options enhance the flexibility of the red tag functionality. Update the `fn_red_tag` function to accept `red_tag_options` and modify the tagging logic accordingly. Also, update the `optional_inputs` to include these new options. This feature update is in line with commit F6ea7c6 of the matlab recover code. The red tag logic for coupling beams is a bit of a patch and should be revisited later for further refactoring.
dustin-cook
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Commit f6ea7c6 and 873205e of the ATC138_prp_updates branch of the matlab codebase.
The updates should not change outcomes of the test data. The main items changed were committed in two separate commits, and include:
Additionally, another commit adds files that documents all the required python package dependencies and provides user guidance in readme