Use per-user cached windows for O(1) rate-limit cooldown reads#115
Merged
ameeribro4-sudo merged 1 commit intoJul 21, 2026
Merged
Conversation
Make hourly_cached and daily_cached use per-user storage keys so each user's cached window boundary is independent. This eliminates cross-user cache invalidation and makes cooldown_ms reads O(1) per user. - Changed cache key from bare symbol to (user, symbol) tuple - Updated all 6 call sites (check/record/status for swap and LP) - Existing bit-shift optimization in fast_window preserved - cleanup_rate_limits already O(1), no changes needed Closes OpenPeerX#65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented per-user cached window boundaries for O(1) cooldown reads in the rate limiter, as requested in the issue.
Changes
hourly_cachedanddaily_cachedcache keys from bare symbol to(user, symbol)tuple, making cached window boundaries per-user instead of globalcheck_swap_limit,record_swap,check_lp_limit,record_lp_op,get_swap_status,get_lp_statusfast_windowpreservedcleanup_rate_limitsalready O(1), no changes neededCloses #65