Minor speedup of diagram loading

OpenPonk · Jul 25, 2024 · 5a9b06b · 5a9b06b
1 parent 3c5a1c5
commit 5a9b06b
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/repository/OpenPonk-Core/OPStonDiagramSerializer.class.st b/repository/OpenPonk-Core/OPStonDiagramSerializer.class.st
@@ -32,13 +32,21 @@ OPStonDiagramSerializer >> formatName [
 { #category : 'serialize/materialize' }
 OPStonDiagramSerializer >> materializeDiagramOf: aModel from: aStream [
 
-	| diagram adapters allModelElements |
+	| diagram adapters innerElements elementsById |
 	diagram := STON fromStream: aStream.
 	adapters := OPNavigatorAdapters new.
-	allModelElements := ((Set with: aModel)
-	                     , (adapters allChildrenFor: aModel) collect: [ 
-		                     :each | each uuid -> each ]) asDictionary.
-	diagram resolveAllModelElements: allModelElements.
+	innerElements := adapters allChildrenFor: aModel.
+	elementsById := Dictionary new: innerElements size + 1.
+	elementsById at: aModel uuid put: aModel.
+	innerElements do: [ :each |
+		elementsById
+			at: each uuid
+			ifPresent: [ :existing |
+				self error:
+					'There are two elements with same ID ' , each uuid asString
+					, ': ' , existing asString , ' and: ' , each asString ]
+			ifAbsentPut: each ].
+	diagram resolveAllModelElements: elementsById.
 	^ diagram
 ]