refactor: remove unused debug.c/h and rename convertion.c to conversi…

…on.h

.gitignore

@@ -17,4 +17,6 @@ local.properties
 cmake-build-*
 lib/
 bin/
-build/
+build/
+test262/
+test262*.txt

README.md

@@ -58,12 +58,6 @@ sudo apt install lldb # Ubuntu
 
 If you're using VSCode, you can use the `C/C++` and `Code LLDB` extension to debug.
 
-Pass this argument to cmake enable debug log on release build.
-
-```
--DCONFIG_DEBUG_ON_RELEASE=1
-```
-
 ### Tests
 
 ```bash

include/quickjs/quickjs.h

@@ -983,9 +983,4 @@ int JS_SetModuleExportList(JSContext* ctx, JSModuleDef* m, const JSCFunctionList
 /* quickjs_rs c bindings */
 #include "quickjs-rs.h"
 
-/* Should use in `jsc` repl only */
-#ifdef CONFIG_DEBUG_ON_RELEASE
-void __internal_debug_log(const char* fmt, ...);
-#endif
-
 #endif /* QUICKJS_H */

scripts/test.sh

@@ -11,4 +11,4 @@ cd test262
 # patch -p1 < ../tests/test262.patch
 cd ..
 touch test262_errors.txt
-./bin/run-test262 -m -c test262.conf -a
+./bin/run-test262 -m -c tests/test262.conf -a

src/CMakeLists.txt

@@ -29,7 +29,7 @@ add_library(quickjs
     core/malloc.c
     core/shape.c
     core/parser.c
-    core/convertion.c
+    core/conversion.c
     core/runtime.c
     core/module.c
     core/ic.c
@@ -56,9 +56,6 @@ add_library(quickjs
     core/builtins/js-string.c
     core/builtins/js-symbol.c
     core/builtins/js-typed-array.c
-
-    # misc
-    core/misc/debug.c
 )
 
 # create a custom target for including headers
@@ -75,18 +72,6 @@ set(QUICKJS_VERSION STRING "0.1.0")
 
 add_compile_options(${COMPILE_FLAGS})
 
-# Debug on release
-if (CONFIG_DEBUG_ON_RELEASE)
-    add_compile_definitions(CONFIG_DEBUG_ON_RELEASE)
-endif()
-
-# Debug on release
-if (CONFIG_DEBUG_ON_RELEASE)
-    target_compile_options(quickjs PUBLIC
-        -DCONFIG_DEBUG_ON_RELEASE
-    )
-endif()
-
 target_compile_options(quickjs PUBLIC
     -D_GNU_SOURCE
     -DCONFIG_BIGNUM

src/core/builtins/js-array.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-array.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"
@@ -867,17 +867,6 @@ JSValue js_array_indexOf(JSContext* ctx, JSValueConst this_val, int argc, JSValu
       if (present < 0)
         goto exception;
       if (present) {
-#ifdef CONFIG_DEBUG_ON_RELEASE
-        __internal_debug_log(
-            "present_str: %s, input_char: %s, present: %d, char: %s, equal: %d",
-            JS_ToCString(ctx,this_val),
-            JS_ToCString(ctx,argv[0]),
-            present,
-            JS_ToCString(ctx, JS_DupValue(ctx, val)),
-            js_strict_eq2(ctx, JS_DupValue(ctx, argv[0]), val, JS_EQ_STRICT),
-            "\n"
-        );
-#endif
         if (js_strict_eq2(ctx, JS_DupValue(ctx, argv[0]), val, JS_EQ_STRICT)) {
           res = n;
           break;

src/core/builtins/js-atomics.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-atomics.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "js-typed-array.h"
 

src/core/builtins/js-big-num.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-big-num.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-date.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-date.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-function.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-function.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../gc.h"

src/core/builtins/js-json.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-json.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-number.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-number.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../object.h"
 #include "../runtime.h"

src/core/builtins/js-object.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-object.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../object.h"
 #include "../runtime.h"

src/core/builtins/js-operator.c

@@ -26,7 +26,7 @@
 
 #include "js-operator.h"
 
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-promise.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-promise.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-proxy.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-proxy.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-regexp.c

@@ -27,7 +27,7 @@
 #include "quickjs/libregexp-opcode.h"
 #include "quickjs/libregexp.h"
 
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-string.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-string.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/builtins/js-typed-array.c

@@ -25,7 +25,7 @@
  */
 
 #include "js-typed-array.h"
-#include "../convertion.h"
+#include "../conversion.h"
 #include "../exception.h"
 #include "../function.h"
 #include "../object.h"

src/core/convertion.c → src/core/conversion.c

@@ -24,7 +24,7 @@
  * THE SOFTWARE.
  */
 
-#include "convertion.h"
+#include "conversion.h"
 #include "builtins/js-big-num.h"
 #include "exception.h"
 #include "function.h"

src/core/convertion.h → src/core/conversion.h

@@ -24,8 +24,8 @@
  * THE SOFTWARE.
  */
 
-#ifndef QUICKJS_CONVERTION_H
-#define QUICKJS_CONVERTION_H
+#ifndef QUICKJS_CONVERSION_H
+#define QUICKJS_CONVERSION_H
 
 #include "quickjs/quickjs.h"
 #include "quickjs/cutils.h"

src/core/function.c

@@ -33,7 +33,7 @@
 #include "builtins/js-object.h"
 #include "builtins/js-operator.h"
 #include "builtins/js-regexp.h"
-#include "convertion.h"
+#include "conversion.h"
 #include "exception.h"
 #include "gc.h"
 #include "module.h"

src/core/object.c

@@ -29,7 +29,7 @@
 #include "builtins/js-object.h"
 #include "builtins/js-operator.h"
 #include "builtins/js-proxy.h"
-#include "convertion.h"
+#include "conversion.h"
 #include "exception.h"
 #include "function.h"
 #include "gc.h"

src/core/parser.c

@@ -25,7 +25,7 @@
 
 #include "parser.h"
 #include "builtins/js-function.h"
-#include "convertion.h"
+#include "conversion.h"
 #include "exception.h"
 #include "function.h"
 #include "bytecode.h"

src/core/runtime.c

@@ -49,7 +49,7 @@
 #include "builtins/js-operator.h"
 #include "builtins/js-reflect.h"
 #include "builtins/js-symbol.h"
-#include "convertion.h"
+#include "conversion.h"
 #include "gc.h"
 #include "module.h"
 #include "object.h"

src/core/string.c

@@ -25,7 +25,7 @@
  */
 
 #include "string.h"
-#include "convertion.h"
+#include "conversion.h"
 #include "exception.h"
 #include "quickjs/cutils.h"
 #include "quickjs/list.h"

src/crates/quickjs_gc/src/record.rs

@@ -4,12 +4,12 @@ use std::sync::{Mutex, Once};
 use quickjs_common::backtrace::Backtrace;
 use crate::{JSGCObjectHeader, ListHead};
 
-// Define a global static Once variable and a static mutable option of the Mutexed HashMap
+/// Define a global static Once variable and a static mutable option of the Mutexed HashMap
 static INIT: Once = Once::new();
 static mut GC_OBJECTS: Option<Mutex<HashMap<*const JSGCObjectHeader, Backtrace>>> = None;
 
-// Function to safely initialize and get a reference to the global
-// HashMap storing garbage-collected objects and their backtraces.
+/// Function to safely initialize and get a reference to the global
+/// HashMap storing garbage-collected objects and their backtraces.
 pub fn get_gc_object_backtrace_map() -> &'static Mutex<HashMap<*const JSGCObjectHeader, Backtrace>> {
     unsafe {
         INIT.call_once(|| {
@@ -19,9 +19,9 @@ pub fn get_gc_object_backtrace_map() -> &'static Mutex<HashMap<*const JSGCObject
     }
 }
 
-// This function records the creation of a garbage-collected object.
-// It takes a raw pointer to the object and stores it along with a
-// backtrace in a global HashMap.
+/// This function records the creation of a garbage-collected object.
+/// It takes a raw pointer to the object and stores it along with a
+/// backtrace in a global HashMap.
 #[no_mangle]
 pub unsafe extern "C" fn record_gc_object_creation(gc_object_link: *mut ListHead) {
     // Convert the pointer to the 'link' field back to a pointer to the encompassing struct

src/libbf.c

@@ -33,7 +33,7 @@
 #endif
 
 #include "mimalloc.h"
-#include "core/convertion.h"
+#include "core/conversion.h"
 #include "quickjs/cutils.h"
 #include "quickjs/libbf.h"
 

tests/test-ecma-262.conf → tests/test262.conf

@@ -26,22 +26,22 @@ module=yes
 verbose=yes
 
 # load harness files from this directory
-harnessdir=test262/harness
+harnessdir=../test262/harness
 
 # names of harness include files to skip
 #harnessexclude=
 
 # name of the error file for known errors
-errorfile=test262_errors.txt
+errorfile=../test262_errors.txt
 
 # exclude tests enumerated in this file (see also [exclude] section)
 #excludefile=test262_exclude.txt
 
 # report test results to this file
-reportfile=test262_report.txt
+reportfile=../test262_report.txt
 
 # enumerate tests from this directory
-testdir=test262/test
+testdir=../test262/test
 
 [features]
 # Standard language features and proposed extensions