-
Notifications
You must be signed in to change notification settings - Fork 20
Give mod own logo #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The logo here looks great. But it taken from assets from .PAK files that user should get himself (preferably bye). I don’t think it is good idea to get image from bigplan.cps. This is why parser for cps file made and this is why current logo.png made: to not to use this one from original .PAK files |
You are overestimating possible copyright issues. This is heavily edited over the .cps file. Modlogo can't be gotten from the original files, and i don't think using a complately custom logo is a good idea for a mod that aims to be as close to original as possible. |
Highly possibly that I overestimate that. But I think better to create logo from scratch without using original assets. Current logo can be replaced of course, but really don’t want to use image from protected by copyright assets |
If you can make something that is 128x128 at least but preferably 256x256, i can resize them and apply them to .ico/.icns files and update this PR. |
You could use something stylized like Also comes with https://github.com/katlogic/dunelegacy/blob/master/dunelegacy.svg a scalable version. |
This look reasonable, but may be better to make own icon. I already set maximum priority to this issue. Will make something |
@evgeniysergeev has there been progress on this? Will you make a logo? Shall we make a logo? Can we use one of the suggested? |
Closes #94.
I didn't use the existing logo at mod folder but replaced it too in PR. I took the image used in the loadscreen (bigplan.cps). Cut the planet out, make it properly circular and resize as necessary.
Also added Website and WebIcon32 defitions to mod.yaml.