core: add ETCS SVL logic to ETCS braking simulator #10402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10402 +/- ##
========================================
Coverage 80.66% 80.67%
========================================
Files 1098 1101 +3
Lines 111787 112573 +786
Branches 744 747 +3
========================================
+ Hits 90176 90813 +637
- Misses 21568 21717 +149
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Erashin
force-pushed
the
alch/core/add_loa_svl_etcs_logic
branch
5 times, most recently
from
5bfa910 to
8350dfe
Compare
Erashin
changed the title
Erashin
force-pushed
the
alch/core/add_loa_svl_etcs_logic
branch
6 times, most recently
from
5fd6dac to
e93a30e
Compare
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
9 times, most recently
from
29d84bb to
6212f99
Compare
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
4 times, most recently
from
ec6da6b to
390b821
Compare
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
3 times, most recently
from
a8a8bb4 to
ce5a895
Compare
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
from
ce5a895 to
7af533a
Compare
bougue-pe
reviewed
Feb 27, 2025
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/Constants.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/Constants.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
from
7af533a to
1e7ce69
Compare
Erashin
commented
Feb 27, 2025
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
4 times, most recently
from
cb65815 to
19652df
Compare
bougue-pe
approved these changes
Feb 28, 2025
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
from
19652df to
fb7fde5
Compare
eckter
approved these changes
Mar 3, 2025
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope_sim/EnvelopeSimPath.java
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
from
fb7fde5 to
574a3e7
Compare
bougue-pe
reviewed
Mar 5, 2025
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
Signed-off-by: Erashin <[email protected]>
Erashin
force-pushed
the
alch/core/add_svl_etcs_logic
branch
from
574a3e7 to
408d683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10404.
Add SVL logic to ETCS braking simulator.
How: compute svl and eoa indications, compute minimum curve, and compare it against overlay.
Limit: approximate braking curves' calculation when SvL is after the end of the path, due to the missing tractive effort and slopes post path.