core: compute ETCS LoA EBD foot and curve more accurately #10565
+93
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## alch/core/compute-min-envelope-part #10565 +/- ##
=======================================================================
+ Coverage 80.84% 81.18% +0.34%
=======================================================================
Files 1115 797 -318
Lines 112518 79825 -32693
Branches 759 759
=======================================================================
- Hits 90961 64809 -26152
+ Misses 21502 14961 -6541
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
from
ad04ea6 to
786fca9
Compare
Erashin
changed the title
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
from
786fca9 to
0d7cb7b
Compare
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
3 times, most recently
from
9237395 to
29b34df
Compare
github-actions
bot
added
the
area:integration-tests
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
6 times, most recently
from
d3c5bb0 to
afef4ad
Compare
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
from
afef4ad to
8ad93aa
Compare
bougue-pe
approved these changes
Feb 14, 2025
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePartBuilder.java
Outdated
Show resolved
Hide resolved
Erashin
commented
Feb 14, 2025
bougue-pe
approved these changes
Feb 14, 2025
eckter
reviewed
Feb 14, 2025
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePartBuilder.java
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
3 times, most recently
from
b33e1a6 to
2b9699b
Compare
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
2 times, most recently
from
931b4d0 to
3749995
Compare
eckter
reviewed
Feb 21, 2025
core/envelope-sim/src/main/kotlin/fr/sncf/osrd/envelope_sim/etcs/ETCSBrakingCurves.kt
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
3 times, most recently
from
fcf5bbd to
46a7572
Compare
Erashin
changed the base branch from
dev
to
alch/core/compute-min-envelope-part
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
from
46a7572 to
c0abe96
Compare
Erashin
commented
Mar 14, 2025
| val guiPosition = | ||
| if (speed > guiCurve.maxSpeed || speed < guiCurve.minSpeed) Double.POSITIVE_INFINITY | ||
| else guiCurve.interpolatePosition(speed) | ||
| if (speed > guiPart.maxSpeed || speed < guiPart.minSpeed) Double.POSITIVE_INFINITY |
There was a problem hiding this comment.
PR is not rebased on DEV yet, this change will disappear to become if(...) guipart.beginPos.
Erashin
force-pushed
the
alch/core/compute-min-envelope-part
branch
2 times, most recently
from
eb8ebd8 to
9ef34ab
Compare
Signed-off-by: Erashin <[email protected]>
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
from
c0abe96 to
320a174
Compare
eckter
approved these changes
Mar 14, 2025
Erashin
force-pushed
the
alch/core/fix-loa-ebd-curve
branch
3 times, most recently
from
283b74b to
320a174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #10564.
Fixes #10430 (see description for further information).