front: add, get and delete paced trains #10966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10966 +/- ##
==========================================
+ Coverage 81.37% 81.41% +0.04%
==========================================
Files 1122 1123 +1
Lines 112696 113120 +424
Branches 758 758
==========================================
+ Hits 91703 92098 +395
- Misses 20938 20967 +29
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SharglutDev
changed the title
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
10 times, most recently
from
5cf88dd to
77ebbd0
Compare
emersion
changed the title
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
from
77ebbd0 to
9d5a8e6
Compare
emersion
reviewed
Mar 7, 2025
...c/modules/trainschedule/components/ManageTrainSchedule/helpers/formatTimetableItemPayload.ts
Outdated
Show resolved
Hide resolved
...c/modules/trainschedule/components/ManageTrainSchedule/helpers/formatTimetableItemPayload.ts
Outdated
Show resolved
Hide resolved
...c/modules/trainschedule/components/ManageTrainSchedule/helpers/formatTimetableItemPayload.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/AddTrainScheduleButton.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/AddTrainScheduleButton.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/checkCurrentConfig.ts
Show resolved
Hide resolved
clarani
reviewed
Mar 7, 2025
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
2 times, most recently
from
d37c225 to
9f154eb
Compare
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
3 times, most recently
from
46934e7 to
b6811f7
Compare
front/src/applications/operationalStudies/hooks/useScenarioData.ts
Outdated
Show resolved
Hide resolved
clarani
reviewed
Mar 19, 2025
front/src/modules/trainschedule/components/ManageTrainSchedule/PacedTrainSettings.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/PacedTrain/PacedTrainItem.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts
Show resolved
Hide resolved
emersion
approved these changes
Mar 19, 2025
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
from
5154a40 to
1adeee8
Compare
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
from
5845574 to
178345d
Compare
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
from
178345d to
d5661d0
Compare
clarani
approved these changes
Mar 21, 2025
front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts
Show resolved
Hide resolved
front/src/modules/trainschedule/components/Timetable/TimetableToolbar.tsx
Outdated
Show resolved
Hide resolved
Maymanaf
reviewed
Mar 21, 2025
Maymanaf
reviewed
Mar 21, 2025
Maymanaf
reviewed
Mar 21, 2025
Maymanaf
reviewed
Mar 21, 2025
Maymanaf
reviewed
Mar 21, 2025
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
2 times, most recently
from
ac8df19 to
b07aced
Compare
The buttons were displayed when hovering the paced train item and the occurrences item when it should be only on paced train hovering. Signed-off-by: SharglutDev <[email protected]>
This extra useEffect introduced a bug in end to end tests. The only way to reproduce it was to set the train name and start time in less that 500ms (the debounce used for these fields) which the e2e tests do. At this speed, after filling the name, a useEffect is fired after 500ms after to update the store, but since the test is also filling the start time a few ms later, the useEffect was called because nameFromStore had been updated resulting in setting the start time back at its original value. A workaround had been done for tests 011 and 012 to insert the selection of the rolling stock between the name and start time filling. Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
pfn/front/add-get-delete-paced-trains
branch
from
b07aced to
8c4dd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits (will be merged all together)
part of #10615
Note
PR is now testable !
As some logic from train schedule has been reused for the pace train mode, be sure to check that all previous behavior when paced train mode is off are still working (add/edit/get/delete, duplicate, import/export, nge, drag, selecting/projecting a train, stdcm)
E2E Tests :