Skip to content

front: add alternative solutions proposals for stdcm #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

achrafmohye
Copy link
Contributor

@achrafmohye achrafmohye commented Feb 27, 2025

closes #10572

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (5159655) to head (7d81c7f).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10970      +/-   ##
==========================================
+ Coverage   80.81%   80.83%   +0.01%     
==========================================
  Files        1120     1122       +2     
  Lines      113171   113310     +139     
  Branches      759      758       -1     
==========================================
+ Hits        91461    91592     +131     
- Misses      21655    21663       +8     
  Partials       55       55              
Flag Coverage Δ
editoast 72.40% <ø> (-0.01%) ⬇️
front 89.93% <100.00%> (+<0.01%) ⬆️
gateway 2.46% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch 3 times, most recently from e02e324 to 91bc2fa Compare March 3, 2025 08:19
@achrafmohye achrafmohye requested review from clarani and Akctarus March 3, 2025 08:22
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from 91bc2fa to 20f9637 Compare March 4, 2025 09:48
@achrafmohye achrafmohye marked this pull request as ready for review March 4, 2025 09:48
@achrafmohye achrafmohye requested a review from a team as a code owner March 4, 2025 09:48
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch 5 times, most recently from 9e3d9f6 to 6778dae Compare March 5, 2025 09:06
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think it would be easier to handle directly the results in your new functions handleSuccess and handleConflicts in order to remove useStdcmResults and the useEffect in StdcmView

@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from 771a931 to 2ae0425 Compare March 6, 2025 11:06
@clarani clarani self-requested a review March 7, 2025 13:43
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from 2ae0425 to 9c22f1a Compare March 11, 2025 09:54
@achrafmohye achrafmohye requested a review from a team as a code owner March 11, 2025 09:54
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from 9c22f1a to 6caa9d4 Compare March 11, 2025 10:51
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch 3 times, most recently from 2f2fec9 to 13a2a27 Compare March 12, 2025 15:03
@clarani clarani changed the title Alternative solutions proposals for stdcm front: add alternative solutions proposals for stdcm Mar 12, 2025
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch 2 times, most recently from 8bd9d88 to 547117b Compare March 12, 2025 16:01
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm !

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good 😄

Only 1 question @thibautsailly, here is the mockup:
image

And here is the app:
image

Is it ok for you if we have the banner takes all the width ? Can we harmonize the padding top and bottom around the main div ?

@clarani
Copy link
Contributor

clarani commented Mar 18, 2025

Discussed with @thibautsailly:

  • the banner should filled all the width (you should just add a margin of 4px on the left/right sides, see the mockup)
  • the horizontal padding in the banner should be 40px
  • the box shadow is not correct (on the mockup, inspect the "elevation" component)
  • you can add some unbreakable space (we can discuss it tomorrow 👍)

@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch 3 times, most recently from ee8f4b2 to cfa5a3c Compare March 19, 2025 16:37
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 4 small comments to fix.
Can you squash your commits and ask a review in the tests channel ?

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Please, can you squash your commits ? You should only merge 2 commits

… empty while consolidating overtakes

Signed-off-by: Achrafmohye <[email protected]>
@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from 7c4f595 to a45370d Compare March 20, 2025 11:16
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@achrafmohye achrafmohye force-pushed the ame/alternative-solutions-STDCM branch from a45370d to 7d81c7f Compare March 20, 2025 11:23
Copy link
Contributor

@Maymanaf Maymanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Maymanaf Maymanaf added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@Maymanaf Maymanaf added this pull request to the merge queue Mar 20, 2025
Merged via the queue into dev with commit b3c1228 Mar 20, 2025
27 checks passed
@Maymanaf Maymanaf deleted the ame/alternative-solutions-STDCM branch March 20, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative Solutions Search and Display for Failed STDCM Simulations
5 participants