-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: convert envelope files to kotlin #11120
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Erashin <[email protected]>
Signed-off-by: Erashin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11120 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 1115 1115
Lines 112495 112509 +14
Branches 759 759
=======================================
+ Hits 90934 90946 +12
- Misses 21506 21508 +2
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.kt
Show resolved
Hide resolved
Yeah ok ngl I only took a couple details into account. The rest kinda fuck the java part up, and ngl, this ain't my code, this is just a kotlin reformat. We discussed it with @eckter we agree it's fine as is. |
Part of #10991, just for an easier way to review and comment this