Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: convert envelope files to kotlin #11120

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

core: convert envelope files to kotlin #11120

wants to merge 2 commits into from

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Mar 13, 2025

Part of #10991, just for an easier way to review and comment this

@eckter eckter requested a review from a team as a code owner March 13, 2025 13:36
@eckter eckter requested review from Khoyo and bougue-pe and removed request for Khoyo March 13, 2025 13:36
@github-actions github-actions bot added the area:core Work on Core Service label Mar 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (1b37d58) to head (4833837).
Report is 10 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11120   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files        1115     1115           
  Lines      112495   112509   +14     
  Branches      759      759           
=======================================
+ Hits        90934    90946   +12     
- Misses      21506    21508    +2     
  Partials       55       55           
Flag Coverage Δ
editoast 72.46% <ø> (-0.01%) ⬇️
front 89.89% <ø> (+<0.01%) ⬆️
gateway 2.49% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 88.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Erashin
Copy link
Contributor

Erashin commented Mar 13, 2025

Yeah ok ngl I only took a couple details into account. The rest kinda fuck the java part up, and ngl, this ain't my code, this is just a kotlin reformat. We discussed it with @eckter we agree it's fine as is.
Taken into account in the origin pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants