front: map: factorize sources #11172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11172 +/- ##
==========================================
- Coverage 80.88% 80.87% -0.01%
==========================================
Files 1119 1120 +1
Lines 112833 112823 -10
Branches 759 759
==========================================
- Hits 91261 91250 -11
- Misses 21517 21518 +1
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tristramg
force-pushed
the
tmg/map_sources
branch
from
686a892 to
e17cac9
Compare
This avoids requesting multiple times the same data on the network Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg
force-pushed
the
tmg/map_sources
branch
from
e17cac9 to
bc407d3
Compare
Signed-off-by: Tristram Gräbener <[email protected]>
Tristramg
force-pushed
the
tmg/map_sources
branch
from
bc407d3 to
12e50be
Compare
|
Code lgtm ^^ |
Synar
approved these changes
Mar 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests separates the map Sources from the Layers. This allows having only one data source if it is used in multiple layers.
There should be no visible change on the map (try adding layers such as OSM Tracks, plateforms, activate terrain…).
In the network console we should notice that there no longer are call multiple times to the same data source
Fixes #11106