Repository navigation
Conversation
Drop the dash between version and date in the 21 release headers that carried one, and add an empty `## Unreleased` section above them, so the box's bump folds pending notes into `## KiteControllers vX.Y.Z YYYY-MM-DD`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It holds per-checkout preferences (Revise, precompile workloads) and is ignored in KiteModels.jl and KiteUtils.jl already. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1-Bort-1
commented
Oct 6, 2026
1-Bort-1
left a comment
Member
Author
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE WITH COMMENTS · 0 inline, 0 off the diff
Good
- Only headers change: against origin/main the diff is 2 files, +24/−21, and every
-line is a header losing its-, which matches the card's scope - All 29
## KiteControllers vheaders now match the regex in the card; I checked every^##line in CHANGELOG.md and only## Unreleasedfalls outside it bin/create_releaseis unaffected, as claimed: its awk matches/^## KiteControllers /and takes$2, so the empty## Unreleasedis skipped and the version field is the same with or without the dash- The
.gitignorefix is around the change and named in the card; the drift inbin/installwas split out as #71 instead of riding along, which follows §1 - No changelog fragment, correctly, since nothing user-visible changed
Not good
- There is no
## KiteControllers v0.2.27header: the v0.2.28 section (lines 38–59) runs straight into v0.2.26, and its### FixedOpenSSL note looks like 0.2.27 content. This predates the PR, but a PR whose goal is a well-formed changelog should name it or open an issue (§5) - Against local
mainthe diff also shows the README and docs image changes from 60ccc69. Localmainis stale, not the branch, but the card's 'up to date withmain' only holds against origin/main LocalPreferences.tomlis appended under a one-offoutput/jetls_…logentry instead of with the other Julia environment ignores. This is cosmetic
claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
…erences.toml ignore Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## Unreleased## Unreleased, restore the lost v0.2.27 section
Member
Author
|
Fixed in f5ccf59: |
Member
Author
|
Local full suite: PASS (11 min, Julia 1.13.0, one cell of the matrix) |
1-Bort-1
marked this pull request as ready for review
October 6, 2026 12:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The 21 release headers that read
## KiteControllers vX.Y.Z - YYYY-MM-DDnow read## KiteControllers vX.Y.Z YYYY-MM-DD, like the eight older ones already did, and an empty## Unreleasedsits above them. That is the one shape the box'sagent releasefolds notes into andbin/release --dry-runrehearses, so a release of this package no longer gets refused over the changelog (1-Bart-1/Agents#608).Only headers changed: a word diff of
CHANGELOG.mdis 21 removed-tokens plus the added## Unreleasedline, and no note text or###subheading moved. All 30 release headers now match^## KiteControllers v[0-9.]+ [0-9]{4}-[0-9]{2}-[0-9]{2}$.How it was checked: the box's
rules/releaserun with--dry-run --shaagainst three commits.ghwas stubbed for auth, repo name and commit lookup, since two of the commits are synthetic and never pushed:Version mismatch: Project.toml is 0.2.31 but CHANGELOG top is (expected v0.2.31). This is expected.bin/releaseonly ever runs on the bump commit, wherewithReleaseinsrc/bump.tshas already replaced## Unreleasedwith a dated header. With an empty section and nochangelog.d/files the bump has nothing to release and declines.## KiteControllers v0.2.32 2026-10-06holding one### Fixednote,version = "0.2.32"):Version: v0.2.32, and the notes come out as that section.Version: v0.2.31, and the v0.2.31 notes come out in full.Found on the way, fixed here: the whole
## KiteControllers v0.2.27section was missing, so the v0.2.28 notes ran straight into v0.2.26. It was dropped by ebae34c (#62, the PythonCall switch), most likely in a merge. Restored verbatim fromCHANGELOG.mdat tagv0.2.27(dated 2026-05-07 there), header in the new form; its notes match the GitHub release for v0.2.27. This is the one place note text enters the diff, and it is text that was already released, not new.Found on the way, fixed here:
LocalPreferences.toml, which holds Revise and precompile settings for a single checkout, was ignored only underexamples/, so every worktree's root copy showed up as an uncommitted change. Theexamples/LocalPreferences.tomlline is now an unanchoredLocalPreferences.toml, which covers both, as KiteModels.jl and KiteUtils.jl already do.Found on the way, split out:
./bin/install -ydoes not run on the box. Under-yit uses the active Julia (1.13) and then refuses everything except 1.11/1.12. It has also drifted from the install contract: it runs the test suite, adds Revise to the shared environment and edits~/.bashrc. That is a separate idea and this markdown change does not need Julia, so it is #71 instead of riding here.bin/create_releasematches on## KiteControllers vand reads only the fields before the date, so dropping the dash does not affect it.Verification
main, 21 headers carried-between version and date, and there was no## Unreleasedfor the bump to fold intorules/release --dry-runrehearsal: the three runs above, output as quoted## Unreleasedgit show v0.2.27:CHANGELOG.mdapart from the header dashrules/releaserehearsal not re-run after the v0.2.27 restore: it reads only the top section, which that commit does not touchagent ci-localnot run, for the same reasonbin/reuse_lint· up to date withorigin/main(60ccc69)-header. A search ofbin/,docs/and.github/found onlybin/create_release, which is unaffected.Scope
+47 / −22 across 2 files. In
CHANGELOG.md: 21 header rewrites,## Unreleasedand its blank line, and the 23-line restored v0.2.27 section. In.gitignore: one line changed,examples/LocalPreferences.toml→LocalPreferences.toml. No changelog fragment, because nothing here is user-visible.Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Closes #70 · task
KiteControllers.jl-70