Repository navigation
KiteModels.jl: a definition for KPS3 and KPS4 #322
Description
Activity
Adding
system_definition(s)for KPS3 and KPS4. It builds a KiteGeometrySystemDefinitionfrom the springs the model actually integrates, adds@reexport using KiteGeometry(pinned through[sources]until the package is registered), and puts the definition in the saved log's metadata undertopology. Stacked on #312, which is now on KiteUtils 0.13.
Not touchingaero_force_b/tether_induced_force: this repo writes neither. Thebin/installfix is in #323.Question from
KiteModels.jl-322I can't stack on #312:
frame-unificationis 29 commits behind main, andagent stack 312fails because of a conflict inCHANGELOG.md, the only file that conflicts (Project.tomlandsrc/KiteModels.jlmerge cleanly). How should I proceed?
A) Mergeorigin/mainintoframe-unification(a merge, not a rebase), push it to #312, then stack on it. I'd resolve only the CHANGELOG hunk.
B) You or #312's author update it, and I stack once it is green.
C) Build on #321 or main and leave #312's frame changes out of this unit.
I recommend A. #312 also has no CI run yet, so the stack would wait on its checks either way. One more thing: nothing in this repo writesaero_force_bortether_induced_force, so thesysstaterename has nothing to change here. The log does need KiteUtils 0.13 forSysLog.metadata, and OpenSourceAWE/KiteViewers.jl#56 gates that.The plan changed what this unit asks for, so the body above is now
kitemodelsasplans/topology_state_split_plan.mdwords it today. Read it again before you go on.27 remaining items
- changed the title
[-]One kite system definition across the Kite packages: KiteModels.jl: a definition for KPS3 and KPS4[/-][+]KiteModels.jl: a definition for KPS3 and KPS4[/+]on Oct 1, 2026
KPS3 and KPS4 describe their system with a scalar segment count and a handful of settings. Build a
SystemDefinitionfrom those instead — points, segments, the tether, the winch — so a KPS4 run can be drawn by anything that reads a definition, which is the whole point of the plan and the thing KiteViewers cannot do today.@reexport using KiteGeometry. The mirror removal of unitmirrorapplies here too where model structs carry positions that belong to the state.sysstateis a need rather than a nicety: this repo writesaero_force_bandtether_induced_forceper step, and those are the fields that unit renames. KiteModels #312 is the open frame pull request here, so it is your base while it is open.The check is that an existing KPS4 example runs unchanged and its log carries a definition whose point count and connectivity match what the model actually integrated.
Unit
kitemodelsof planplans/topology_state_split_plan.md, tracked in 1-Bart-1/Agents#294.https://github.com/1-Bart-1/Agents/blob/4ee7e2b839cdd358bef56ef3b00097f4b5702f50/plans/topology_state_split_plan.md