Repository navigation
cleanup: bin/install runs the test suite and edits the machine; make... #323
Description
Activity
31 remaining items
Question from
KiteModels.jl-323Should #323 be closed as won't-fix, or kept open for a yes/no per point?
- @ufechner7 closed bin/install only installs: copy the pinned manifest, instantiate, precompile #326 with "No". The numbered list on cleanup: bin/install runs the test suite and edits the machine; make... #323 (comment 5855354302) has no per-point answers yet.
- @1-Bart-1 backed point 1 (no Pkg.test in install) and point 2 (no juliaup default).
- If 1 and 2 are agreed, I would redo the branch with only those two changes, which gets ./bin/install -y back to exit 0 on 1.13. Nothing else in bin/install would change.
My recommendation is to do only points 1 and 2, since together they fix the failure the issue reports. I won't push anything until one of you says which way to go.
cleanup: bin/install runs the test suite and edits the machine; make it only install
./bin/install -y exits 1 on a fresh worktree because it runs
Pkg.test()after instantiating (currently 539 passed, 2 errored, 11 broken on Julia 1.13 — the errors look like #314), so the box reports the environment as uninstallable although instantiate and precompile succeeded. Per the ecosystem's install contract the script should copy Manifest-v.toml.default, instantiate and precompile, and nothing else: no test run, nojuliaup default, no alias appended to ~/.bashrc, no Pkg.add of Revise into the global environment.-yshould also use the Julia already on the machine rather thanjuliaup add. Found while installing the worktree for #322.