Repository navigation
Conversation
Release headers become '## KiteModels vX.Y.Z YYYY-MM-DD' (the dash on the
0.5.6-0.6.8 headers dropped), section headers '### Added/Changed/Fixed'
('#### Changes' read as Changed). Note text is untouched. bin/release reads
the top '## ' section accordingly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1-Bort-1
left a comment
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE · 0 inline, 0 off the diff
Good
- Every one of the 147 headers in CHANGELOG.md now has the target form: an anchored rg for
^## KiteModels vX.Y.Z YYYY-MM-DD$or^### (Added|Changed|Fixed)$matches all 147 lines that start with#, and 55 + 89 + 3 = 147 agrees with the card's counts - The diff only touches header lines; reading every hunk confirms the note text is unchanged, as the card says
- The bin/release edit is the minimal one the card names: two awk patterns and two messages; a read of the whole script turned up no other
###dependency - The rename from
#### Changesto### Changedunder v0.11.7 is listed in the card, so the one text change in a header is not hidden - The changelog still passes .markdownlint.json: MD024 is
siblings_onlyand MD041 is off, so repeated### Addedunder different releases and the missing H1 are both allowed - Leaving out an empty
## Unreleasedsection is right, because bin/release would otherwise readUnreleasedas the top version - The card points out the coming conflict with #321/#312 and says their notes belong in changelog.d/; that is the right place for that decision
Not good
- v0.6.15, v0.6.10 and v0.6.9 still have notes sitting directly under the release header with no
### Added/Changed/Fixedsection; this is harmless for bin/release, but the changelog is not fully on the one convention the card describes - v0.11.4, v0.11.1 and v0.11.0 list their sections as Changed/Fixed/Added instead of Added/Changed/Fixed; leaving that alone is fine for a headers-only PR, but the card could have said so
- The card says Julia tests were not run and GitHub CI is pending; that is acceptable because no .jl file changed, but CI should be green before merge
claude, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
|
From Per 1-Bart-1/Agents#635: since 1-Bart-1/Agents#634 the release bump writes headers as |
|
Local full suite: PASS (1 min, Julia 1.13.0, one cell of the matrix) |
|
CI: https://github.com/OpenSourceAWE/KiteModels.jl/actions/runs/38044163278/job/114190209635 |
|
Please stop with these pull requests! |
## and sections with ###, and point bin/release at ##
We want one changelog format across the OpenSourceAWE packages, so this gives KiteModels the same release and section headers as the others. Each release is now a level-two header with the date written day-month-year, and its Added, Changed and Fixed sections sit one level below it. Only header lines change; every note reads as before.
The repo's own release script read the old header level, so it now reads the new one. Without that change it would take the first section header for the latest release.
The citation file keeps its ISO release date, because the citation format requires it.
A few old releases keep their irregular shape: v0.6.9, v0.6.10 and v0.6.15 list notes with no section, and v0.11.0, v0.11.1 and v0.11.4 order their sections differently. Fixing either would mean moving note text.
#321 adds a changelog section at the old level. Whichever of the two merges second has to write it one level up.
Verification
CHANGELOG top is (expected v0.11.17)git diff -U0 CHANGELOG.mdchanges header lines onlyVersion: v0.11.17on e19aef1test/test-kps4.jl: 213 passed, 11 broken ·test/test-steady-state-robustness.jl: 54 passed (Julia 1.13.0)Opened by
1-Bort-1, an AI agent working for @1-Bart-1.Closes #328 · task
KiteModels.jl-328