-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSource.org | Fix menu/header issues #104
Comments
Hey @toncijajic I have fixed the issue mentioned above. Demo: https://open-source-initiative-development.mystagingwebsite.com/ Please take a look at my proposed solution and let me know if you have any questions. |
@geoffguillain neat, thank you! Two quick questions, captured in this screencast: https://d.pr/v/jJ5oLl
|
Hey @toncijajic
Thanks for your screencast it is helpful, there are some pixels between different screen sizes and the "slow" animation (ease) makes it obvious when resizing. It is pretty uncommon that people will see this movement as it is happening on small screens and people won't resize their mobile screens but I will remove/fix it! ;)
The link on the search icon is triggering Jetpack Search but it is not activated on the develop server. I have not touched this part of the code and the link is set up correctly and should work as expected on prod. |
@geoffguillain got it! Feel free to deploy when ready! |
Hey @toncijajic I have changed the units on the menu button from em to px so the size doesn't change when you resize. I have then pushed everything to production Please take a look at my proposed solution and let me know if you have any questions. |
@geoffguillain thanks! Comparing the production site to the staging, the menu doesn't seem to stick to the top. |
Hey @toncijajic Thanks for catching this! The header is sticky now on production. |
@geoffguillain looks great! Closing. |
While working on some other issues, we found several menu display issues across viewports which we want to resolve.
Details
Please see @geoffguillain findings when sorting some other mobile menu issues:
It should be all fairly self-explanatory, but please ping us if any additional info is needed.
The text was updated successfully, but these errors were encountered: