Multiday Watering Levels, Weather Restriction, Current Fault Detect by rayshobby · Pull Request #272 · OpenSprinkler/OpenSprinkler-App

rayshobby · 2025-08-28T17:08:41Z

Summary

UI support for multiday watering levels (using historical water data for programs that run on a regular interval) and weather restrictions
UI support for current fault detection (overcurrent and undercurrent)
Fix 24-hr time not showing in log and preview
Update the old links-timeline library to the more modern vis-timeline library
Misc. bug fixes such as broken new firmware release notification, remote http port missing leading 0,

…rograms in app.

…sions.

… switch.

…App into multidayETo

…rinkler-App into multidayETo

…App into multidayETo

…rinkler-App into multidayETo

…er to preserve station run order in the annotation

github-actions · 2025-08-28T17:09:49Z

Visit the preview URL for this PR (updated for commit b1f06e4):

https://opensprinkler-devui--pr272-multidayeto-saxr97a9.web.app

_{(expires Fri, 05 Sep 2025 18:10:40 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 9b7a984849dffe48c01bc0242f5c0f93b14ed1df}

salbahra · 2025-08-28T17:13:35Z

@codex

chatgpt-codex-connector · 2025-08-28T17:13:44Z

@codex

For now, I can only help with PRs you've created.

Copilot

Pull Request Overview

This PR introduces support for multiday watering levels using historical weather data, weather restrictions, and current fault detection, while also updating the timeline visualization library and fixing time display issues.

Adds multiday watering level calculations using historical weather data for programs with regular intervals
Implements weather restriction options (rain amount/days, temperature thresholds, California restriction)
Adds overcurrent and undercurrent fault detection with UI notifications

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
www/js/modules/weather.js	Updates weather delay adjustment options and forecast display with precipitation data
www/js/modules/utils.js	Fixes JSON escaping method to properly handle braces
www/js/modules/system-diagnostics.js	Adds multiday levels and weather restriction status to diagnostics display
www/js/modules/supported.js	Adds version check for weather restrictions feature
www/js/modules/status.js	Changes status colors and adds overcurrent fault detection
www/js/modules/stations.js	Updates run-once submission to support annotations and improved dialog handling
www/js/modules/programs.js	Migrates from links-timeline to vis-timeline library and implements multiday watering level logic
www/js/modules/options.js	Adds weather restriction configuration UI and updates current threshold options
www/js/modules/logs.js	Updates timeline visualization to use vis-timeline library with proper time formatting
www/js/modules/language.js	Adds call to update weather restriction notice
www/js/modules/firmware.js	Improves firmware update detection with minor version handling
www/js/modules/dates.js	Fixes 12/24-hour time format display throughout the application
www/js/modules/dashboard.js	Adds weather restriction notice to dashboard and fixes remote station hex encoding
www/js/main.js	Updates option constants for current limits
www/index.html	Adds vis-timeline library dependencies
www/css/vis-timeline-graph2d.min.css	New CSS file for vis-timeline library
www/css/main.css	Updates timeline styling for new vis-timeline library

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-28T17:15:20Z

+				if ( typeof OSApp.currentSession.weather.forecast[ i ].precip !== "undefined") {
+					list += "<span>" + OSApp.Language._( "Forecasted Rain" ) + "</span><span>: " + OSApp.Weather.formatPrecip( OSApp.currentSession.weather.forecast[ i ].precip ) + "</span>"


Missing semicolon after the string concatenation on line 843. This could cause JavaScript parsing issues.

Suggested change

if ( typeof OSApp.currentSession.weather.forecast[ i ].precip !== "undefined") {

list += "" + OSApp.Language._( "Forecasted Rain" ) + ": " + OSApp.Weather.formatPrecip( OSApp.currentSession.weather.forecast[ i ].precip ) + ""

list += "" + OSApp.Language._( "Forecasted Rain" ) + ": " + OSApp.Weather.formatPrecip( OSApp.currentSession.weather.forecast[ i ].precip ) + "";

Copilot · 2025-08-28T17:15:21Z

+	return wto && OSApp.Firmware.checkOSVersion( 2213 );
+}


Missing semicolon after the function declaration on line 100.

Suggested change

return wto && OSApp.Firmware.checkOSVersion( 2213 );

}

};

Copilot · 2025-08-28T17:15:22Z


+	// Show overcurrent fault status
+	if ( OSApp.currentSession.controller.settings.ocs ) {
+		OSApp.Status.changeStatus( 0, "red", "<p class='running-text center'>" + OSApp.Language._( "Overcurrent Fault detected" ) + ( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( " when opening Station " + OSApp.currentSession.controller.settings.ocs ) ) + "!!</p>" );


[nitpick] The double exclamation marks ('!!') in the error message are unprofessional. Consider using a single exclamation mark or removing them entirely for a more professional error message.

Suggested change

OSApp.Status.changeStatus( 0, "red", "" + OSApp.Language._( "Overcurrent Fault detected" ) + ( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( " when opening Station " + OSApp.currentSession.controller.settings.ocs ) ) + "!!" );

OSApp.Status.changeStatus( 0, "red", "" + OSApp.Language._( "Overcurrent Fault detected" ) + ( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( " when opening Station " + OSApp.currentSession.controller.settings.ocs ) ) + "!" );

Copilot · 2025-08-28T17:15:23Z

+	} else {
+		$( "#restr-active" ).addClass("hidden");
+	}
+}


Missing semicolon after the function declaration.

Suggested change

}

};

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

salbahra · 2025-08-29T18:11:08Z

+	// Show overcurrent fault status
+	if ( OSApp.currentSession.controller.settings.ocs ) {
+		OSApp.Status.changeStatus( 0, "red", "<p class='running-text center pointer'>" + OSApp.Language._( "Overcurrent Fault detected" ) +
+			( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( OSApp.Language._( " when opening Station " ) + OSApp.currentSession.controller.settings.ocs ) ) + "!!</p>",


The double exclamation mark is not needed here. Rachio notifies me all the time over and under current and it isn't as alarming.

Ncp294 and others added 30 commits June 27, 2025 12:13

Added support for selection of historical weather data for interval p…

420ca39

…rograms in app.

Inclusion of Zimmerman for mutliDay weather usage.

3c9abee

Change forecast date format to display month abbreviations.

8fddb02

Escape JSON bug fix and movement of California restriction to wto.

c568bc8

Initial support for editing rain restriction variables

aa41c62

Support for min temp restriction, stylization, and bug fixes.

c6b420c

Added metric and negative temperature support for restrictions.

98075ca

Changed auto firmware update notification to work with new minor revi…

b8585e1

…sions.

Fixed incorrect group display bug for last station and added break to…

c68173f

… switch.

Added display for the multiday watering scales

bbb3962

Fixed leading 0 bug in remote station port.

4bacc70

Display changes for muti-day watering scales.

4858751

UI support for under/overcurrent fault alert

7beb68d

Refactor restrictions to not be in nested object in wto.

169f427

minor UI changes

bf76041

minor UI changes

f2edd3c

Fixed short term saving bug with weather restrictions.

436e339

wording change to make the multiday checkbox more clear

28b5c47

Merge branch 'multidayETo' of github.com:OpenSprinkler/OpenSprinkler-…

bc19d19

…App into multidayETo

Change of name from hwt to mda for multi day flag.

100156e

resolve merge conflict

5194bfd

Merge branch 'master' into multidayETo

a8ad1e7

Merge branch 'multidayETo' of github.com:OpenSprinkler/OpenSprinkler-…

27120b3

…App into multidayETo

Quick bug fix of name change reverting in merge.

a64c2e8

minor wording change

7db6331

Fix with persistence in mda selection

1292086

Merge branch 'multidayETo' of https://github.com/OpenSprinkler/OpenSp…

c8dff21

…rinkler-App into multidayETo

Adjustment of manual and autoRainDelay to support use of restrictions.

5510d47

minor wording change

fb06c5f

Merge branch 'feature/current-fault-detect' into multidayETo

6b8e581

Ncp294 and others added 12 commits August 27, 2025 09:38

Revert of dwl changes due to new restriction flag

d35d9bc

minor wording change

37025c6

Merge branch 'multidayETo' of github.com:OpenSprinkler/OpenSprinkler-…

9e38b37

…App into multidayETo

Visual cues for when weather restrictions are active

969817f

Merge branch 'multidayETo' of github.com:OpenSprinkler/OpenSprinkler-…

a8d9a24

…App into multidayETo

Logic changes for status indication

58a6d83

Merge branch 'multidayETo' of github.com:OpenSprinkler/OpenSprinkler-…

77b00b7

…App into multidayETo

Quick bug fix

9e1f8b0

Merge branch 'multidayETo' of https://github.com/OpenSprinkler/OpenSp…

04ff2d1

…rinkler-App into multidayETo

guard mda checkbox against firmware version; minor wording changes

1d3d7d9

add multiday feature to preview; minor UI tweaking

82581e1

allow runonce program to replicate the program name annotation in ord…

c6e7e7e

…er to preserve station run order in the annotation

rayshobby linked an issue Aug 28, 2025 that may be closed by this pull request

Default weather date format is ambiguous #268

Closed

salbahra requested a review from Copilot August 28, 2025 17:12

Copilot AI reviewed Aug 28, 2025

View reviewed changes

rayshobby and others added 8 commits August 28, 2025 14:36

address PR review comments including semicolons

e526140

Styling change for enable logging button

c83978e

fix weather restrict showing on page load

fd474e8

display dname as site name when local

4cc48ac

add vis-timeline library to home.js

5ef6ef0

minor wording change

6795fdd

add more informative message to overcurrent fault detection

e9f3614

Apply suggestion from @Copilot

b1f06e4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

salbahra reviewed Aug 29, 2025

View reviewed changes

salbahra approved these changes Aug 29, 2025

View reviewed changes

salbahra merged commit 37377c0 into master Sep 2, 2025
6 checks passed

salbahra deleted the multidayETo branch September 2, 2025 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiday Watering Levels, Weather Restriction, Current Fault Detect#272

Multiday Watering Levels, Weather Restriction, Current Fault Detect#272
salbahra merged 59 commits into
masterfrom
multidayETo

rayshobby commented Aug 28, 2025

Uh oh!

github-actions Bot commented Aug 28, 2025 •

edited

Loading

Uh oh!

salbahra commented Aug 28, 2025

Uh oh!

chatgpt-codex-connector Bot commented Aug 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 28, 2025

Uh oh!

Uh oh!

Copilot AI Aug 28, 2025

Uh oh!

Copilot AI Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Aug 28, 2025

Uh oh!

Uh oh!

salbahra Aug 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		if ( typeof OSApp.currentSession.weather.forecast[ i ].precip !== "undefined") {
		list += "<span>" + OSApp.Language._( "Forecasted Rain" ) + "</span><span>: " + OSApp.Weather.formatPrecip( OSApp.currentSession.weather.forecast[ i ].precip ) + "</span>"

	OSApp.Status.changeStatus( 0, "red", "<p class='running-text center'>" + OSApp.Language._( "Overcurrent Fault detected" ) + ( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( " when opening Station " + OSApp.currentSession.controller.settings.ocs ) ) + "!!</p>" );
	OSApp.Status.changeStatus( 0, "red", "<p class='running-text center'>" + OSApp.Language._( "Overcurrent Fault detected" ) + ( OSApp.currentSession.controller.settings.ocs === 255 ? "" : ( " when opening Station " + OSApp.currentSession.controller.settings.ocs ) ) + "!</p>" );

Conversation

rayshobby commented Aug 28, 2025

Summary

Uh oh!

github-actions Bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salbahra commented Aug 28, 2025

Uh oh!

chatgpt-codex-connector Bot commented Aug 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

salbahra Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Aug 28, 2025 •

edited

Loading