Catching errors on requests

example_config.js

@@ -6,5 +6,6 @@ exports.irc = {
 }
 
 exports.github = {
-  private_atom : 'http://atom_http_url.com/'
+  host : '' // Your host, without https (myhost.com)
+, path : '' // Your path (/mypage.php?lol=1)
 }

github.js

@@ -1,13 +1,26 @@
 var http = require('http')
   , xml   = require('xml2json')
   , bot
+  , options = {
+      host : ''
+    , path : ''
+    , method : 'GET'
+    }
+  , time = 1000 * 60 * 1 // 1 Minute
 
 exports.init = function(_bot) {
   bot = _bot
 
-  setInterval(function() {
-    http.get(bot.config.github.private_atom, gotResults)
-  }, 1000 * 60 * 1) // 1 Minute
+  options.host = bot.config.github.host
+  options.path = bot.config.github.path
+
+  makeRequests()
+}
+
+function makeRequests() {
+  var req = http.request(options, gotResults)
+  req.end()
+  req.on('error', gotError)
 }
 
 function gotResults(res) {
@@ -16,6 +29,17 @@ function gotResults(res) {
     data += chunk
   })
   res.on('end', function() {
-    bot.controller.githubFeed(JSON.parse(xml.toJson(data)))
+    try {
+      data = JSON.parse(xml.toJson(data))
+    } catch(e) {
+      return gotError(e)
+    }
+    bot.controller.githubFeed(data)
+    setTimeout(makeRequests, time)
   })
 }
+
+function gotError(error) {
+  console.log(error)
+  setTimeout(makeRequests, time)
+}

twitter.js

@@ -1,12 +1,21 @@
 var http = require('http')
   , bot
+  , options = {
+      host : 'search.twitter.com'
+    , path : '/search.json?q=OpenVE&rpp=5&result_type=recent'
+    , method : 'GET'
+    }
+  , time = 1000 * 30 // 30 Seconds
 
 exports.init = function(_bot) {
   bot = _bot
+  makeRequests()
+}
 
-  setInterval(function() {
-    http.get('http://search.twitter.com/search.json?q=OpenVE&rpp=5&result_type=recent', gotResults)
-  }, 1000 * 60 * 0.5) // 30 Seconds
+function makeRequests() {
+  var req = http.request(options, gotResults)
+  req.end()
+  req.on('error', gotError)
 }
 
 function gotResults(res) {
@@ -15,6 +24,17 @@ function gotResults(res) {
     data += chunk
   })
   res.on('end', function() {
-    bot.controller.twitterSearch(JSON.parse(data))
+    try {
+      data = JSON.parse(data)
+    } catch(e) {
+      return gotError(e)
+    }
+    bot.controller.twitterSearch(data)
+    setTimeout(makeRequests, time)
   })
 }
+
+function gotError(error) {
+  console.log(error)
+  setTimeout(makeRequests, time)
+}