Skip to content

[enigma2] Fix PiG video flash when opening a child screen #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Huevos merged 1 commit into from
May 29, 2026
Merged

[enigma2] Fix PiG video flash when opening a child screen #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/gui/evideo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,16 @@ int eVideoWidget::event(int event, void *data, void *data2)

eVideoWidget::~eVideoWidget()
{
updatePosition(1);
/* Only restore fullscreen if this widget has ever set the video position.
m_state & 1 means updatePosition() was called and the position was committed.
This avoids restoring fullscreen when the widget was never active. */
if (m_state & 1)
{
pendingFullsize |= (1 << m_decoder);
forceFullsizeDecoder |= (1 << m_decoder);
eVideoWidget::setPosition(m_decoder, posFullsizeLeft, posFullsizeTop, posFullsizeWidth, posFullsizeHeight);
fullsizeTimer->start(100, true);
}
}

void eVideoWidget::setFBSize(eSize size)
Expand Down Expand Up @@ -134,10 +143,10 @@ void eVideoWidget::updatePosition(int disable)
else
{
m_state &= ~8;
pendingFullsize |= (1 << m_decoder);
forceFullsizeDecoder |= (1 << m_decoder);
eVideoWidget::setPosition(m_decoder, posFullsizeLeft, posFullsizeTop, posFullsizeWidth, posFullsizeHeight);
fullsizeTimer->start(100, true);
/* Do NOT restore fullscreen here. The widget is only temporarily hidden
(e.g. a child screen is opening on top). Restoring fullscreen now would
cause a visible flash before the child screen finishes painting.
Fullscreen is restored by the destructor when the widget is actually destroyed. */
}
}

Expand Down
Loading