Fix: RL training on e830 NIC #1295
Closed
+31
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakoram
force-pushed
the
Fix_RL_traning_on_e830
branch
from
c3fe4ee to
5ca41bb
Compare
| /* If the measured speed is lower than expected. Set higher bps and retrain to add | ||
| * padding */ | ||
| /* padding can only help if the actual throughput is slightly higher than expected. */ | ||
| if (measured_bps > rl_bps && pad_interval > 32) { |
There was a problem hiding this comment.
please add explanation to this magic number
Sakoram
force-pushed
the
Fix_RL_traning_on_e830
branch
2 times, most recently
from
38f86d2 to
7d2998b
Compare
Rl training failed when measured throughput was significantly bigger then expected. Fixed by adding retraining in this case. Signed-off-by: Kasiewicz, Marek <[email protected]>
|
continue in #1307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rl training failed for st20 when measured throughput was
significantly bigger then expected. Fixed by adding retraining in this case.
Fixed for st30 by extending acceptable range