Add TrieProof library #5826
Draft
Add TrieProof library #5826
+597
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Arr00 <[email protected]>
🦋 Changeset detectedLatest commit: fd7d2b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| function verify( | ||
| bytes memory key, | ||
| bytes memory value, | ||
| bytes[] memory proof, |
There was a problem hiding this comment.
Reminder that proofs are almost always provided via calldata, as such calldata should be used here for reduced gas costs.
Comment on lines
+246
to
+253
| function _nibbles(bytes memory value) private pure returns (bytes memory) { | ||
| uint256 length = value.length; | ||
| bytes memory nibbles_ = new bytes(length * 2); | ||
| for (uint256 i = 0; i < length; i++) { | ||
| (nibbles_[i * 2], nibbles_[i * 2 + 1]) = (value[i] & 0xf0, value[i] & 0x0f); | ||
| } | ||
| return nibbles_; | ||
| } |
There was a problem hiding this comment.
Reminder, a much more efficient approached has been added to Solady.
EDIT: more context https://graphics.stanford.edu/~seander/bithacks.html#InterleaveBMN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #5680
PR Checklist
npx changeset add)