build(ci): optimize CI jobs #824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qalisander
reviewed
Aug 28, 2025
|
|
||
| - name: Install rust | ||
| - name: Install Rust toolchain | ||
| uses: actions-rust-lang/setup-rust-toolchain@v1 |
There was a problem hiding this comment.
I do remember the main reason I've added this gh action: it has caching features.
Wasn't it working before?
If it doesn't work may be just drop it?
0xNeshi
reviewed
Sep 8, 2025
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install rust | ||
| - name: Install Rust toolchain |
There was a problem hiding this comment.
The name changes are useful, but the additional caching steps don't seem to be reducing the run time 🤔
Maybe I'm missing something?
There was a problem hiding this comment.
Yeah. We need to research that later and address this pr towards main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.