-
Notifications
You must be signed in to change notification settings - Fork 47
publish GH workflow #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
publish GH workflow #554
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request establishes project governance and automation infrastructure by adding a CODEOWNERS file, introducing a GitHub Actions workflow for automated crate publishing, and explicitly versioning a workspace dependency constraint. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/publish-crates.yml:
- Around line 44-48: The Publish job is running in parallel with dry-run; add an
explicit dependency so publishing only runs after dry-run succeeds by adding a
needs: [dry-run] entry to the publish job definition (reference the job id
"publish" and the dry-run job id "dry-run") so the publish job will wait for the
dry-run job to complete successfully.
🧹 Nitpick comments (1)
.github/workflows/publish-crates.yml (1)
7-9: Consider using a stable ref for concurrency grouping.For tag pushes,
${{ github.head_ref || github.run_id }}makes the group unique per run, socancel-in-progresswon’t de‑dupe. Usinggithub.ref_namewill group by tag.♻️ Suggested tweak
concurrency: - group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + group: ${{ github.workflow }}-${{ github.ref_name }} cancel-in-progress: true
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 54 54
Lines 5201 5201
=======================================
Hits 4997 4997
Misses 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This PR adds a gh action for publishing some of the workspace members to crates.io. It also sets an explicit version to "stellar-contract-utils" in the main Cargo.toml, because "stellar-tokens" depends on it and cannot be published without explicit version.
Also added codeowners.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.