add tests

step-generation/src/__tests__/absorbanceReaderCloseLid.test.ts

@@ -0,0 +1,83 @@
+import { beforeEach, describe, it, expect, vi } from 'vitest'
+import {
+  ABSORBANCE_READER_TYPE,
+  ABSORBANCE_READER_V1,
+} from '@opentrons/shared-data'
+import {
+  getErrorResult,
+  makeContext,
+  getInitialRobotStateStandard,
+} from '../fixtures'
+import { absorbanceReaderCloseLid } from '../commandCreators/atomic/absorbanceReaderCloseLid'
+import { absorbanceReaderStateGetter } from '../robotStateSelectors'
+import type {
+  AbsorbanceReaderState,
+  InvariantContext,
+  RobotState,
+} from '../types'
+
+const moduleId = 'absorbanceReaderId'
+vi.mock('../robotStateSelectors')
+
+describe('absorbanceReaderCloseLid', () => {
+  let invariantContext: InvariantContext
+  let robotState: RobotState
+  beforeEach(() => {
+    invariantContext = makeContext()
+    invariantContext.moduleEntities[moduleId] = {
+      id: moduleId,
+      type: ABSORBANCE_READER_TYPE,
+      model: ABSORBANCE_READER_V1,
+    }
+    robotState = getInitialRobotStateStandard(invariantContext)
+    robotState.modules[moduleId] = {
+      slot: 'D3',
+      moduleState: {
+        type: ABSORBANCE_READER_TYPE,
+        initialization: null,
+        lidOpen: false,
+      },
+    }
+    vi.mocked(absorbanceReaderStateGetter).mockReturnValue(
+      {} as AbsorbanceReaderState
+    )
+  })
+  it.only('creates absorbance reader close lid command', () => {
+    const module = moduleId
+    const result = absorbanceReaderCloseLid(
+      {
+        module,
+        commandCreatorFnName: 'absorbanceReaderCloseLid',
+      },
+      invariantContext,
+      robotState
+    )
+    expect(result).toEqual({
+      commands: [
+        {
+          commandType: 'absorbanceReader/closeLid',
+          key: expect.any(String),
+          params: {
+            moduleId: module,
+          },
+        },
+      ],
+    })
+  })
+  it('creates returns error if bad module state', () => {
+    const module = moduleId
+    vi.mocked(absorbanceReaderStateGetter).mockReturnValue(null)
+    const result = absorbanceReaderCloseLid(
+      {
+        module,
+        commandCreatorFnName: 'absorbanceReaderCloseLid',
+      },
+      invariantContext,
+      robotState
+    )
+    expect(getErrorResult(result).errors).toHaveLength(1)
+    expect(getErrorResult(result).errors[0]).toMatchObject({
+      type: 'MISSING_MODULE',
+    })
+  })
+})

step-generation/src/__tests__/absorbanceReaderOpenLid.test.ts

@@ -0,0 +1,83 @@
+import { beforeEach, describe, it, expect, vi } from 'vitest'
+import {
+  ABSORBANCE_READER_TYPE,
+  ABSORBANCE_READER_V1,
+} from '@opentrons/shared-data'
+import {
+  getErrorResult,
+  makeContext,
+  getInitialRobotStateStandard,
+} from '../fixtures'
+import { absorbanceReaderOpenLid } from '../commandCreators/atomic/absorbanceReaderOpenLid'
+import { absorbanceReaderStateGetter } from '../robotStateSelectors'
+import type {
+  AbsorbanceReaderState,
+  InvariantContext,
+  RobotState,
+} from '../types'
+
+const moduleId = 'absorbanceReaderId'
+vi.mock('../robotStateSelectors')
+
+describe('absorbanceReaderOpenLid', () => {
+  let invariantContext: InvariantContext
+  let robotState: RobotState
+  beforeEach(() => {
+    invariantContext = makeContext()
+    invariantContext.moduleEntities[moduleId] = {
+      id: moduleId,
+      type: ABSORBANCE_READER_TYPE,
+      model: ABSORBANCE_READER_V1,
+    }
+    robotState = getInitialRobotStateStandard(invariantContext)
+    robotState.modules[moduleId] = {
+      slot: 'D3',
+      moduleState: {
+        type: ABSORBANCE_READER_TYPE,
+        initialization: null,
+        lidOpen: false,
+      },
+    }
+    vi.mocked(absorbanceReaderStateGetter).mockReturnValue(
+      {} as AbsorbanceReaderState
+    )
+  })
+  it('creates absorbance reader open lid command', () => {
+    const module = moduleId
+    const result = absorbanceReaderOpenLid(
+      {
+        module,
+        commandCreatorFnName: 'absorbanceReaderOpenLid',
+      },
+      invariantContext,
+      robotState
+    )
+    expect(result).toEqual({
+      commands: [
+        {
+          commandType: 'absorbanceReader/openLid',
+          key: expect.any(String),
+          params: {
+            moduleId: module,
+          },
+        },
+      ],
+    })
+  })
+  it('creates returns error if bad module state', () => {
+    const module = moduleId
+    vi.mocked(absorbanceReaderStateGetter).mockReturnValue(null)
+    const result = absorbanceReaderOpenLid(
+      {
+        module,
+        commandCreatorFnName: 'absorbanceReaderOpenLid',
+      },
+      invariantContext,
+      robotState
+    )
+    expect(getErrorResult(result).errors).toHaveLength(1)
+    expect(getErrorResult(result).errors[0]).toMatchObject({
+      type: 'MISSING_MODULE',
+    })
+  })
+})

step-generation/src/commandCreators/atomic/absorbanceReaderCloseLid.ts

@@ -1,14 +1,17 @@
 import { uuid } from '../../utils'
 import { missingModuleError } from '../../errorCreators'
-import { getModuleState } from '../../robotStateSelectors'
+import { absorbanceReaderStateGetter } from '../../robotStateSelectors'
 import type { AbsorbanceReaderLidArgs, CommandCreator } from '../../types'
 
 export const absorbanceReaderCloseLid: CommandCreator<AbsorbanceReaderLidArgs> = (
   args,
   invariantContext,
   prevRobotState
 ) => {
-  const absorbanceReaderState = getModuleState(prevRobotState, args.module)
+  const absorbanceReaderState = absorbanceReaderStateGetter(
+    prevRobotState,
+    args.module
+  )
   if (args.module == null || absorbanceReaderState == null) {
     return {
       errors: [missingModuleError()],

step-generation/src/commandCreators/atomic/absorbanceReaderOpenLid.ts

@@ -1,16 +1,18 @@
 import { uuid } from '../../utils'
 import { missingModuleError } from '../../errorCreators'
-import { getModuleState } from '../../robotStateSelectors'
+import { absorbanceReaderStateGetter } from '../../robotStateSelectors'
 
-import type { ModuleOnlyParams } from '@opentrons/shared-data/protocol/types/schemaV4'
-import type { CommandCreator } from '../../types'
+import type { AbsorbanceReaderLidArgs, CommandCreator } from '../../types'
 
-export const absorbanceReaderOpenLid: CommandCreator<ModuleOnlyParams> = (
+export const absorbanceReaderOpenLid: CommandCreator<AbsorbanceReaderLidArgs> = (
   args,
   invariantContext,
   prevRobotState
 ) => {
-  const absorbanceReaderState = getModuleState(prevRobotState, args.module)
+  const absorbanceReaderState = absorbanceReaderStateGetter(
+    prevRobotState,
+    args.module
+  )
   if (args.module == null || absorbanceReaderState == null) {
     return {
       errors: [missingModuleError()],