feat(robot-server): separate can logs from other serial logs #16686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, CAN messages are stored in the same logging file as serial communications from modules. This means that if, for example, an abr bug occurs, and the logs are grabbed even a few minutes later, a present thermocycler will have sent so many status messages that the CAN messages from when the error happened are pushed out of the logs.
Let's give the CAN messages their own file so we have a better idea of what happened when we need to look at logs.
Changelog
opentrons-api-serial-canbus
logger to the logs routermaxbytes
from1000000
to5000000
was actually done in an attempt to capture CAN messages along with the serial messages, so revert that