Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot-server): separate can logs from other serial logs #16686

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Nov 5, 2024

Overview

Currently, CAN messages are stored in the same logging file as serial communications from modules. This means that if, for example, an abr bug occurs, and the logs are grabbed even a few minutes later, a present thermocycler will have sent so many status messages that the CAN messages from when the error happened are pushed out of the logs.

Let's give the CAN messages their own file so we have a better idea of what happened when we need to look at logs.

Changelog

  • add an entry for the existing opentrons-api-serial-canbus logger to the logs router
  • the change in the serial log's maxbytes from 1000000 to 5000000 was actually done in an attempt to capture CAN messages along with the serial messages, so revert that

@caila-marashaj caila-marashaj changed the title create can logging config element and configs feat(robot-server): separate can logs from other serial logs Nov 5, 2024
@caila-marashaj caila-marashaj marked this pull request as ready for review November 5, 2024 17:41
@caila-marashaj caila-marashaj requested a review from a team as a code owner November 5, 2024 17:41
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it works on a machine! Thank you!

@caila-marashaj caila-marashaj force-pushed the separate-serial-logging branch from 8cb6f81 to 0d96659 Compare November 5, 2024 19:22
@caila-marashaj caila-marashaj force-pushed the separate-serial-logging branch from 0d96659 to 8412fe2 Compare November 5, 2024 19:34
@caila-marashaj caila-marashaj merged commit beede80 into edge Nov 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants