feat(protocol-designer): initial absorbance reader stepform UI #17280
+427
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the initial UI for absorbance reader steps. It creates the new AbsorbanceReaderTools component in line with our other step form toolbox components, and modularizes its children components for cleanliness. The content of both pages 1 and 2 of the form are determined by 1) module initialization state, and 2) labware presence or lack thereof. According to designs, the UI will funnel the user into the correct step form type (lid, initializaton, or reading) based on those 2 inputs. Also implicated here are creation and wiring up of the following methods: patch to pre-select an absorbance reader module if only one is available, form change handlers for absorbance reader dependent fields, absorbance reader module option getter. Closes AUTH-1264
jerader
reviewed
Jan 15, 2025
...designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/AbsorbanceReaderTools/index.tsx
Show resolved
Hide resolved
|
fyi, this is not related but noticed that MoaM placement isn't correct when adding multiple from the onboarding flow 
|
thanks, just ticketed |
jerader
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
looks great, nice work! just left the comment about the useEffect. You should be able to get access to the latest robot state in the patch to get the initialization info and labware info, similarly to what we do for _patchThermocyclerFields accessing latest robot state
koji
reviewed
Jan 15, 2025
...r/src/pages/Designer/ProtocolSteps/StepForm/StepTools/AbsorbanceReaderTools/ReadSettings.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Jan 15, 2025
| const { formData, propsForFields, toolboxStep } = props | ||
| const { moduleId } = formData | ||
| const dispatch = useDispatch() | ||
| const { t } = useTranslation() |
koji
reviewed
Jan 15, 2025
...ol-designer/src/steplist/formLevel/handleFormChange/dependentFieldsUpdateAbsorbanceReader.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the initial UI for absorbance reader steps. It creates the new AbsorbanceReaderTools component in line with our other step form toolbox components, and modularizes its children components for cleanliness. The content of both pages 1 and 2 of the form are determined by:
According to designs, the UI will funnel the user into the correct step form type (lid, initializaton, or reading) based on those 2 inputs. Also implicated here are creation and wiring up of the following methods:
Closes AUTH-1264
Test Plan and Hands on Testing
Because of the conditional nature of this step form content, it is slightly difficult to test the UI thoroughly at present. Functionality will be able to be thoroughly tested in a fast-follow PR that wires up step generation and allows for module controls to be manipulated.
Changelog
Review requests
Risk assessment
low