Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): get labware location from current step index #17297

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 17, 2025

closes RQA-3774

Overview

Previous logic was grabbing the labware location from the latest move labware step for the whole protocol but didn't account for if you are opening up a previously made step earlier on in the protocol before the labware moved. So now, the logic takes that certain step id index into account

Test Plan and Hands on Testing

upload the attached protocol and look at step 10. see that the labware in the dropdown menu are not ending with "cutoutD3", should instead say "off-deck"

Zymo_Magbead_DNA_Cells-Flex_96_channel Truly fixed.json

Additionally, you can test moving a labware to multiple locations and checking that the slot number in the dropdown properly updates.

Changelog

  • fix logic to grab location at certain step index
  • align logic for move labware field and labware field in transfer steps

Risk assessment

low

@jerader jerader requested a review from a team as a code owner January 17, 2025 14:12
@jerader jerader requested review from koji and ncdiehl11 January 17, 2025 14:13
@jerader jerader merged commit 95089e1 into chore_release-pd-8.3.0 Jan 17, 2025
18 checks passed
@jerader jerader deleted the pd_latest-location branch January 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants