Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): oT-2 TC labware highlight refine logic #17302

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 17, 2025

closes RQA-3849

Overview

Accidentally highlighted all the labware when hovering over the TC labware

Test Plan and Hands on Testing

Test the attached protocol and hover over the labware in the move labware dropdown. see that the highlights occur in the correct locations

untitled (36).json

Changelog

make logic more specific for checking labware slot as well

Risk assessment

low

@jerader jerader requested a review from a team as a code owner January 17, 2025 17:09
@jerader jerader requested review from koji and ncdiehl11 January 17, 2025 17:10
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 2e858a7 into chore_release-pd-8.3.0 Jan 18, 2025
24 checks passed
@jerader jerader deleted the pd_tc-ot2-highlight branch January 18, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants