Repository navigation
ci: open the next release PR only once the release is tagged - #50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-please ran both halves of its work in one step: it created the release as a draft (no tag, by design, until the image is published) and then, in the same step, looked for the latest release to open the next PR. With the new tag not there yet, it takes the version before as the latest, counts every change since then again and opens a release PR for the version after the one being published. unified-api hit this releasing v0.38.0 (a bogus
chore: release v0.39.0); this workflow is the same file.Change
release.ymlruns release-please twice, with the publish between them, as in unified-api (OpusProjects/unified-api#290):skip-github-pull-request): creates the draft release when the merge was a release PR's.skip-github-release): opens or updates the next release PR and dispatches its CI. It runs after the publish, when the new tag exists, and is skipped when the publish failed; re-running the failed publish job runs it too.docs/releasing.mddescribes the new step.Compatibility
No change for users.
Checklist
ci)