Feature/literal flag options by redxeth · Pull Request #191 · Origen-SDK/origen_testers

redxeth · 2023-04-14T22:42:09Z

Added ability to do additonal custom changes to flag names-- in case user has particular requirements.

Flag name modifications:

Added ability to substitute the word "FAILED" for any custom word. Also abilty to change "PASSED" and "RAN" as part of flag name also.
Added ability to put the type of flag (fail/pass/ran) first instead of last in the name.

See environment/*_literals.rb files for examples.

when defining flag names, to support NXP flag naming requirements. Old flag naming is the default.

files. User will have to handle as part of the flag ID. Added option to remove flow id MD5 hash from flag name. (Thao doing this work).

not extern type flag names.

redxeth · 2023-04-24T02:13:50Z

Any comments? Should I just merge it? Need to make a new release. @ginty @priyavadan @pderouen @chrisnappi

pderouen · 2023-04-24T12:59:00Z

I've been holding my peace on this one. The changes suit our purposes. Thank you for this PR. From what I can tell the change maintains the previous behavior as the default. So, I think it's good to go. @priyavadan, feel free to weigh in.

The only update I would request is to document these new options in the guides page.

info-rchitect · 2023-04-24T13:03:53Z

I've been holding my peace on this one. The changes suit our purposes. Thank you for this PR. From what I can tell the change maintains the previous behavior as the default. So, I think it's good to go. @priyavadan, feel free to weigh in.

The only update I would request is to document these new options in the guides page.

Agreed on the docs update

priyavadan

looks OK to me. I just verified internally that the default behavior stays the same.

I'll second the request to add more documentation around this feature in the guides though.

redxeth · 2023-04-24T16:58:44Z

Yep-- I was expecting the doc thing from you guys. Can someone remind me how to update the docs again for something OrigenTesters specific? Is there a procedure for this somewhere?

First update docs in the plug-in-- then? Will Origen main guides pick up the change automatically?

pderouen · 2023-04-24T17:29:12Z

Yep-- I was expecting the doc thing from you guys. Can someone remind me how to update the docs again for something OrigenTesters specific? Is there a procedure for this somewhere?

First update docs in the plug-in-- then? Will Origen main guides pick up the change automatically?

It's been a while. But, I believe you update the guides in templates/origen_guides/program of origen_testers. After it's merged, the website can be updated by running web compile -r from origen.

redxeth · 2023-04-25T00:10:47Z

It's been a while. But, I believe you update the guides in templates/origen_guides/program of origen_testers. After it's merged, the website can be updated by running web compile -r from origen.

Yes web compile -r is to regen and publish a new website-- I forgot about the way they are shared-- so the web publish / deploy within the OrigenTesters plug-in will only update that folder on the main origen website looks like.

redxeth · 2023-04-25T22:47:29Z

Ok so in the process of making some updates, I'm seeing lots of lint changes-- I assume that's what all these recent rubocop PRs are about?

So to confirm @priyavadan @pderouen @CodyBriscoe -- my options are either to confirm the rubocop recommendations don't break OrigenTesters or add the exceptions?

And all of this because of the rubocop upgrade needed for Ruby 3.1 ?

UGH-- this is why people are so loathe to make Origen updates on their own (I'm doing this for someone else)

redxeth · 2023-04-25T22:55:19Z

If someone could help fix would appreciate it-- having to go look through multiple PRs-- If this breaks many plugins then we have a lot of 'splaining to do lucy'

pderouen · 2023-04-26T13:02:37Z

Ok so in the process of making some updates, I'm seeing lots of lint changes-- I assume that's what all these recent rubocop PRs are about?

So to confirm @priyavadan @pderouen @CodyBriscoe -- my options are either to confirm the rubocop recommendations don't break OrigenTesters or add the exceptions?

And all of this because of the rubocop upgrade needed for Ruby 3.1 ?

UGH-- this is why people are so loathe to make Origen updates on their own (I'm doing this for someone else)

There are a few more options. I took my best shot at setting up the Rubocop rules so it wouldn't be too disruptive.

If we think there are more rules that need to be turned off, that can be done.
We could also have a custom ruleset for origen_testers.
We could add a third "legacy" option to origen lint.
We might be able to add an origen dependency to the Gemfile and restrict it to the last version before the Rubocop update. That would keep the regression checks running with the older version.

Since it's my group causing the need for this PR and me that made the Ruby 3 updates, I should probably help figure out the right solution.

redxeth · 2023-04-26T13:45:13Z

Since it's my group causing the need for this PR and me that made the Ruby 3 updates, I should probably help figure out the right solution.

Thanks @pderouen ! We should as a group decide on how to handle 'breaking' changes done in Origen and all plug-ins. If there is a breaking change (and here I realize the code isn't broken but needs to be upgraded to match some upgrade in a plug-in).

Do poeple still use the discord server? I checked and see the latest post from last year.

Perhaps github issues? If something new we think may break others then file an issue with attention to the core team, etc., of what things need to be done. Or add a deprecate warning somehow.

Or if it has already broken something, then file an issue here - which I can do and add you @pderouen so that in case others encounter this they understand it's a known issue and how to resolve.

pderouen · 2023-04-26T14:00:08Z

Since it's my group causing the need for this PR and me that made the Ruby 3 updates, I should probably help figure out the right solution.

Thanks @pderouen ! We should as a group decide on how to handle 'breaking' changes done in Origen and all plug-ins. If there is a breaking change (and here I realize the code isn't broken but needs to be upgraded to match some upgrade in a plug-in).

Do poeple still use the discord server? I checked and see the latest post from last year.

Perhaps github issues? If something new we think may break others then file an issue with attention to the core team, etc., of what things need to be done. Or add a deprecate warning somehow.

Or if it has already broken something, then file an issue here - which I can do and add you @pderouen so that in case others encounter this they understand it's a known issue and how to resolve.

You were on all of the issues and PR's for the Rubocop update. All of the discussions about it were had in the monthly global team calls. Agreed, there could also be a bulletin or something of that sort. Unfortunately, there just wasn't a way to stay current with Ruby and keep the ancient version of Rubocop that origen was previously locked with. We'll see if the ruleset can be further refined to make it less disruptive.

By the way there is still 1 open PR on origen that is needed for it to work with Ruby > 3.0.

pderouen · 2023-04-27T13:57:45Z

I am working through the lint errors and will push an update to this PR soon. Some of the failures seem to be highlighting bugs. For those, I will just disable the check for that piece of code and file an issue rather than piling on to this PR.

redxeth · 2023-04-27T16:18:08Z

You were on all of the issues and PR's for the Rubocop update. All of the discussions about it were had in the monthly global team calls.

Yeah sorry-- have a hard time keeping up sometimes with everything.

redxeth · 2023-04-27T16:19:06Z

I am working through the lint errors and will push an update to this PR soon. Some of the failures seem to be highlighting bugs. For those, I will just disable the check for that piece of code and file an issue rather than piling on to this PR.

Wow thanks for your help!

pderouen · 2023-04-27T16:26:45Z

I am working through the lint errors and will push an update to this PR soon. Some of the failures seem to be highlighting bugs. For those, I will just disable the check for that piece of code and file an issue rather than piling on to this PR.

Wow thanks for your help!

It's the least I could do. The lint fix is coming in just a minute. I apologize in advance for the huge number of additional diffs. But, since we already reviewed the content of the PR and approved it hopefully won't be an issue.

pderouen · 2023-04-27T16:30:21Z

lib/origen_testers/atp/flow.rb

+
+          # Legacy option provided by OrigenTesters that permits override of a block enable method by passing
+          # an :or option with a true value
+          if (CONDITION_KEYS[method] == :if_enabled || CONDITION_KEYS[method] == :unless_enabled) && options[:or]


this fixes #192

redxeth added 6 commits March 31, 2023 12:57

Updates made by Thao Huynh and Daniel Hadad to support extra optionality

4d13cd5

when defining flag names, to support NXP flag naming requirements. Old flag naming is the default.

Updates to support option to include flow file name in flag names.

8d8f200

Updates for replacing RAN name as well. And remove unnecessary flag.

049dda7

Removed flow name override as doesn't work when generating multiple flow

a93e83b

files. User will have to handle as part of the flag ID. Added option to remove flow id MD5 hash from flag name. (Thao doing this work).

(Thao update) Corrected flow id inclusion for flow flag names that are

8fb107c

not extern type flag names.

Removed unused option.

f78cd3a

redxeth added the enhancement label Apr 14, 2023

redxeth requested review from chrisnappi, ginty, pderouen and priyavadan April 14, 2023 22:42

priyavadan approved these changes Apr 24, 2023

View reviewed changes

redxeth added 2 commits April 25, 2023 15:16

Updated to include v93k literals test cases.

f3872cc

Added missing referenced.list files in approved dir.

8bb9fec

lint fixes

b778f76

pderouen reviewed Apr 27, 2023

View reviewed changes

pderouen approved these changes Apr 27, 2023

View reviewed changes

Conversation

redxeth commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

redxeth commented Apr 24, 2023

Uh oh!

pderouen commented Apr 24, 2023

Uh oh!

info-rchitect commented Apr 24, 2023

Uh oh!

priyavadan left a comment

Choose a reason for hiding this comment

Uh oh!

redxeth commented Apr 24, 2023

Uh oh!

pderouen commented Apr 24, 2023

Uh oh!

redxeth commented Apr 25, 2023

Uh oh!

redxeth commented Apr 25, 2023

Uh oh!

redxeth commented Apr 25, 2023

Uh oh!

pderouen commented Apr 26, 2023

Uh oh!

redxeth commented Apr 26, 2023

Uh oh!

pderouen commented Apr 26, 2023

Uh oh!

pderouen commented Apr 27, 2023

Uh oh!

redxeth commented Apr 27, 2023

Uh oh!

redxeth commented Apr 27, 2023

Uh oh!

pderouen commented Apr 27, 2023

Uh oh!

pderouen Apr 27, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

redxeth commented Apr 14, 2023 •

edited

Loading