🎨 Palette: standardizing InteractionPrompt accessibility with aria-keyshortcuts and tests - #2474
Conversation
…yshortcuts and add tests - Added aria-keyshortcuts="e" to InteractionPrompt button component to match visual E hotkey - Added comprehensive unit test coverage in InteractionPrompt.test.tsx using JSDOM environment - Documented learnings in the Palette journal (.Jules/palette.md)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abdf0fd902
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,93 @@ | |||
| /** @vitest-environment jsdom */ | |||
There was a problem hiding this comment.
The root vitest.config.ts only includes tests under __tests__, server/src, client/src, and portal/src, so this new apps/client-2d/src/ui test is not collected by the repository's documented npx vitest run command. Extend the include patterns or move the suite into a collected location; otherwise these three regression tests provide no protection in the standard test run.
AGENTS.md reference: AGENTS.md:L37-L40
Useful? React with 👍 / 👎.
1 participant
High-fidelity micro-UX accessibility improvement for the 2D pixel client, standardizing the floating interaction prompt button with
aria-keyshortcuts="e"matching the visual E key hint. Covers the component with full unit tests.PR created automatically by Jules for task 1244114874011577878 started by @OuroborosCollective