Skip to content

Support spaces when opening files in external code editor #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriengivry merged 2 commits into from
Apr 30, 2026
Merged

Support spaces when opening files in external code editor #787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4153e5
fix(editor): quote code editor path placeholders
Gopmyc Apr 30, 2026
0052b67
fix(editor): normalize quoted code editor placeholders
Gopmyc Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Sources/OvEditor/src/OvEditor/Core/EditorActions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,8 +1036,16 @@ bool OvEditor::Core::EditorActions::OpenInCodeEditor(const std::filesystem::path
return false;
}

OvTools::Utils::String::ReplaceAll(command, "{workdir}", p_workdir ? p_workdir->string() : m_context.projectFolder.string());
OvTools::Utils::String::ReplaceAll(command, "{path}", p_path.string());
auto preferredWorkdir = p_workdir ? p_workdir.value() : m_context.projectFolder;
preferredWorkdir.make_preferred();

const std::string quotedWorkdir = std::format("\"{}\"", preferredWorkdir.string());
const std::string quotedPath = std::format("\"{}\"", preferredPath.string());

OvTools::Utils::String::ReplaceAll(command, "\"{workdir}\"", "{workdir}");
OvTools::Utils::String::ReplaceAll(command, "\"{path}\"", "{path}");
OvTools::Utils::String::ReplaceAll(command, "{workdir}", quotedWorkdir);
OvTools::Utils::String::ReplaceAll(command, "{path}", quotedPath);
if (!OvTools::Utils::SystemCalls::ExecuteCommand(command))
{
OVLOG_ERROR(std::format("Failed to open in code editor using command: \"{}\"", command));
Expand Down