Refocus trainer dashboard on actionable stats - #64
Merged
Conversation
Move Needs Attention and Recently Worked to the top of the page since those are what a trainer uses to decide what to do next. Remove the decorative Career Highlights and Skills You've Worked Most sections and their backing computations, and drop the retrospective "look back at your training career" framing for a direct description. Closes #27
Owner
Author
|
One small behavioral mismatch remains before merge: the follow-up scope asks for refined/actionable statistics to appear first, but |
Address review feedback on PR #64: the Refined view (which omits dogs marked Excluded from Stats) is the more actionable of the two success-rate views, so it should be the default and appear first among the toggle buttons, matching the dashboard's actionable-first ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalLogs,logsThisWeek,logsThisMonth,milestonesCompleted,skillsWorkedOnTotal,mostWorkedSkills, theSkillWorkedCounttype, and the now-unuseddaysAgoLocalDatehelper) fromuseTrainerHistoryStats.Your Dogs,Success Rate, andFinal Evaluation Outcomesare unchanged in content, just reordered below the actionable sections.Why
Issue #27's follow-up scope asked for a prioritization/subtraction pass on the existing stats page — put actionable statistics first, drop the decorative career-retrospective sections, and don't replace them with equally decorative summaries. This PR does exactly that without adding any new analytics.
Validation
npm run build— production TypeScript and Vite build passednpm test— 28 tests passednpm run lint— passed with the same 3 pre-existing warnings asmain(unrelated to this change)Closes #27
Generated by Claude Code