Skip to content

Add bin/test --build-only, which runs the test build and stops - #1155

Merged
CleanCut merged 1 commit into
mainfrom
cleancut/test-build-only
Nov 2, 2026
Merged

CleanCut merged 1 commit into
mainfrom
cleancut/test-build-only

Conversation

@CleanCut

@CleanCut CleanCut commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Add --build-only to bin/test, which runs the cargo build a test run starts with and then exits, so a script that warms a checkout's target/ for later bin/test runs builds exactly what they reuse, without a copy of the build command that can drift. It skips the ramdisk, leaves test data alone, and refuses -p.

Add `--build-only` to `bin/test`, which runs the `cargo build` a test run starts with and then
exits, so a script that warms a checkout's `target/` for later `bin/test` runs builds exactly what
they reuse, without a copy of the build command that can drift. It skips the ramdisk, leaves test
data alone, and refuses `-p`.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a324db2 and 197921e.

Files selected for processing: 2
  • AGENTS.md
  • bin/test

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 3 remain after this review.

Summary

Summary by CodeRabbit

  • New Features
    • Added a --build-only option to bin/test to build the Rust workspace binaries and tests without starting the server or running tests.
    • The option cannot be combined with -p or --python; doing so exits with status 2.
  • Documentation
    • Updated the command usage guidance to describe the new option and its restriction.

The bin/test script adds --build-only to build Rust workspace binaries and tests, then exit before server startup or test execution. The option cannot be combined with -p. Build-only mode skips ramdisk setup and test-data cleanup.

Changes: Build-only command

Layer / File(s) Summary
Add and validate the build-only option
bin/test, AGENTS.md
The script documents and parses --build-only. It exits with status 2 if the option is combined with -p/--python. The building commands document the new option.
Skip test setup and exit after the build
bin/test
Build-only mode skips test-data and ramdisk cleanup and ramdisk setup. After cargo build, the script exits before server startup and test execution.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • Oxen-AI/Oxen#1120: This PR configures macOS DYLD_LIBRARY_PATH for Cargo build and test commands in bin/test, including the Cargo build used by build-only mode when both changes are present.
Merge Risk: Minimal · up to 19792

The new option provides the documented build-only workflow without introducing an established merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding a --build-only option to bin/test that builds and stops.
Description check Passed The description directly explains the --build-only behavior, purpose, and restrictions described in the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@CleanCut
CleanCut merged commit 2b0a743 into main Nov 2, 2026
9 checks passed
@CleanCut
CleanCut deleted the cleancut/test-build-only branch November 2, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants