feat: allow plotting intermediate results#30
Merged
sbillinge merged 2 commits intoPDF-bl:mainfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ycexiao
commented
Feb 5, 2026
Contributor
Author
ycexiao
left a comment
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| self.input_files_running = [] | ||
| self.adapter = PDFAdapter() | ||
| self.data_for_plot = {} | ||
| self.visualization_data = {} |
Contributor
Author
There was a problem hiding this comment.
rename data_for_plot to visualization_data
| "reduced_chi2", | ||
| ] | ||
| for entry_name in self.inputs.get("plot_result_entry_names", []): | ||
| for entry_name in self.inputs.get("plot_result_names", []): |
Contributor
Author
There was a problem hiding this comment.
rename plot_result_entry_names to plot_result_names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Closes #27.
Also plot results during
least_squarerefinements.What should the reviewer(s) do?
Please check the modifications.