fix: remove diffpy.cmi from pip.txt and use python=3.11,3.12,3.13 in pyproject.toml#40
Closed
ycexiao wants to merge 2 commits intoPDF-bl:mainfrom
Closed
fix: remove diffpy.cmi from pip.txt and use python=3.11,3.12,3.13 in pyproject.toml#40ycexiao wants to merge 2 commits intoPDF-bl:mainfrom
diffpy.cmi from pip.txt and use python=3.11,3.12,3.13 in pyproject.toml#40ycexiao wants to merge 2 commits intoPDF-bl:mainfrom
Conversation
…3` in `pyproject.toml`
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ycexiao
commented
Feb 18, 2026
Contributor
Author
ycexiao
left a comment
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
requirements/pip.txt
Outdated
| @@ -1,2 +1 @@ | |||
| numpy | |||
| diffpy.cmi | |||
Contributor
Author
There was a problem hiding this comment.
diffpy.cmi should be installed via conda because of the diffpy.srreal module.
sbillinge
reviewed
Feb 18, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Let's make sure the docs are clear that conda must be used and not pip
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Closes #39
What should the reviewer(s) do?
Please check the modifications.